Skip to content

Fix link #2508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 7, 2024
Merged

Fix link #2508

merged 3 commits into from
Jul 7, 2024

Conversation

artola
Copy link
Contributor

@artola artola commented Jul 7, 2024

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

The documentation says:

@mdx-js/mdx is a unified pipeline — wrapped so that most folks don’t need to know about unified: core.js#L65.

and such line states:

@Property {string | null | undefined} [pragma='React.createElement']

I would suggest to avoid linking to the source code, as it is likely to be broken again. Even a permalink will become obsolete overtime.

@vercel Vercel
Copy link

vercel bot commented Jul 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mdx ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2024 6:11pm

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (908ff45) to head (4e9c965).
Report is 34 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #2508   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines         2693      2712   +19     
  Branches         2         2           
=========================================
+ Hits          2693      2712   +19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wooorm
wooorm reviewed Jul 7, 2024
View reviewed changes
@wooorm
Update packages/mdx/readme.md
4e9c965 
Signed-off-by: Titus <tituswormer@gmail.com>
@wooorm wooorm changed the title fix broken link Fix link Jul 7, 2024
@wooorm wooorm merged commit f1ca4b2 into mdx-js:main Jul 7, 2024
@wooorm wooorm added the 💪 phase/solved Post is done label Jul 7, 2024
@wooorm
Copy link
Member

wooorm commented Jul 7, 2024

Thank you! :)

This was referenced Nov 11, 2024
Open
Open
@qdraw qdraw mentioned this pull request Nov 12, 2024
Merged
@renovate renovate bot mentioned this pull request Jan 3, 2025
Open
1 task
@renovate renovate bot mentioned this pull request Jul 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

Assignees
No one assigned
Labels
💪 phase/solved Post is done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artola @codecov-commenter @wooorm