fix: take `cwd` into cache key account #577

JounQin · 2025-05-16T06:34:25Z

Initial checklist

I read the support docs
I read the contributing guide
I agree to follow the code of conduct
I searched issues and discussions and couldn’t find anything or linked relevant results below
I made sure the docs are up to date
I included tests (or that’s not needed)

Description of changes

follow #571

changeset-bot · 2025-05-16T06:34:28Z

🦋 Changeset detected

Latest commit: 698dfee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
eslint-mdx	Patch
eslint-plugin-mdx	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot

Pull Request Overview

This PR fixes caching issues by incorporating the current working directory (cwd) into cache key generation and standardizes the use of the import.meta.url value.

Introduces a constant for import.meta.url to improve consistency in module requiring across files.
Updates the cache key in the remark processor to include cwd and a delimiter to differentiate paths.
Removes the redundant "module-sync" export in package.json.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
packages/eslint-plugin-mdx/src/helpers.ts	Uses a constant (importMetaUrl) for cjsRequire for improved clarity.
packages/eslint-plugin-mdx/package.json	Removes the deprecated "module-sync" field.
packages/eslint-mdx/src/worker.ts	Updates getRemarkConfig and getRemarkProcessor to consider cwd in cache.
packages/eslint-mdx/src/helpers.ts	Applies the same importMetaUrl change for cjsRequire usage.
packages/eslint-mdx/package.json	Removes the deprecated "module-sync" field.

codesandbox-ci · 2025-05-16T06:34:54Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codecov · 2025-05-16T06:34:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4661fe2) to head (698dfee).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##            master      #577   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          270       272    +2     
  Branches        46        46           
=========================================
+ Hits           270       272    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-05-16T06:35:47Z

📊 Package size report `No changes`

File	Before	After
Total _{(Includes all files)}	`4.4 MB`	`4.4 MB`
Tarball size	`1.2 MB`	`1.2 MB`

Unchanged files

File	Size
`.babelrc`	`35 B`
`.changeset/config.json`	`372 B`
`.changeset/README.md`	`510 B`
`.codesandbox/ci.json`	`76 B`
`.editorconfig`	`145 B`
`.env.yarn`	`44 B`
`.gitattributes`	`35 B`
`.github/FUNDING.yml`	`204 B`
`.github/workflows/ci.yml`	`1.5 kB`
`.github/workflows/codeql.yml`	`1.1 kB`
`.github/workflows/pkg-size.yml`	`863 B`
`.github/workflows/release.yml`	`1.3 kB`
`.nano-staged.js`	`48 B`
`.prettierignore`	`38 B`
`.renovaterc`	`49 B`
`.simple-git-hooks.js`	`49 B`
`.yarn/plugins/plugin-prepare-lifecycle.cjs`	`202 B`
`.yarn/releases/yarn-4.9.1.cjs`	`3.0 MB`
`.yarnrc.yml`	`397 B`
`CHANGELOG.md`	`283 B`
`CONTRIBUTING.md`	`931 B`
`eslint.config.js`	`1.2 kB`
`LICENSE`	`1.1 kB`
`package.json`	`3.3 kB`
`packages/eslint-mdx/CHANGELOG.md`	`27.6 kB`
`packages/eslint-mdx/index.d.cts`	`52 B`
`packages/eslint-mdx/package.json`	`1.7 kB`
`packages/eslint-mdx/README.md`	`12.2 kB`
`packages/eslint-mdx/shim.d.ts`	`1.2 kB`
`packages/eslint-mdx/src/helpers.ts`	`3.4 kB`
`packages/eslint-mdx/src/index.ts`	`141 B`
`packages/eslint-mdx/src/meta.ts`	`206 B`
`packages/eslint-mdx/src/parser.ts`	`2.5 kB`
`packages/eslint-mdx/src/sync.ts`	`404 B`
`packages/eslint-mdx/src/tokens.ts`	`6.8 kB`
`packages/eslint-mdx/src/types.ts`	`2.2 kB`
`packages/eslint-mdx/src/worker.ts`	`23.0 kB`
`packages/eslint-mdx/tsconfig.json`	`166 B`
`packages/eslint-plugin-mdx/CHANGELOG.md`	`31.6 kB`
`packages/eslint-plugin-mdx/index.d.cts`	`52 B`
`packages/eslint-plugin-mdx/package.json`	`1.5 kB`
`packages/eslint-plugin-mdx/README.md`	`12.2 kB`
`packages/eslint-plugin-mdx/src/configs/base.ts`	`311 B`
`packages/eslint-plugin-mdx/src/configs/code-blocks.ts`	`1.1 kB`
`packages/eslint-plugin-mdx/src/configs/flat.ts`	`818 B`
`packages/eslint-plugin-mdx/src/configs/index.ts`	`454 B`
`packages/eslint-plugin-mdx/src/configs/overrides.ts`	`781 B`
`packages/eslint-plugin-mdx/src/configs/recommended.ts`	`1.5 kB`
`packages/eslint-plugin-mdx/src/from-markdown.ts`	`291 B`
`packages/eslint-plugin-mdx/src/helpers.ts`	`760 B`
`packages/eslint-plugin-mdx/src/index.ts`	`161 B`
`packages/eslint-plugin-mdx/src/meta.ts`	`207 B`
`packages/eslint-plugin-mdx/src/processors/helpers.ts`	`753 B`
`packages/eslint-plugin-mdx/src/processors/index.ts`	`218 B`
`packages/eslint-plugin-mdx/src/processors/markdown.ts`	`14.8 kB`
`packages/eslint-plugin-mdx/src/processors/options.ts`	`1.6 kB`
`packages/eslint-plugin-mdx/src/processors/remark.ts`	`1.9 kB`
`packages/eslint-plugin-mdx/src/processors/types.ts`	`464 B`
`packages/eslint-plugin-mdx/src/rules/index.ts`	`149 B`
`packages/eslint-plugin-mdx/src/rules/remark.ts`	`3.6 kB`
`packages/eslint-plugin-mdx/src/rules/types.ts`	`430 B`
`packages/eslint-plugin-mdx/src/worker.ts`	`403 B`
`packages/eslint-plugin-mdx/tsconfig.json`	`153 B`
`patches/@1stg+eslint-config+9.0.5.patch`	`510 B`
`README.md`	`12.2 kB`
`test/__snapshots__/fixtures.test.ts.snap`	`45.4 kB`
`test/__snapshots__/parser.test.ts.snap`	`1.1 MB`
`test/fixtures.test.ts`	`3.2 kB`
`test/fixtures/287.mdx`	`204 B`
`test/fixtures/292.mdx`	`191 B`
`test/fixtures/334.mdx`	`70 B`
`test/fixtures/336.mdx`	`178 B`
`test/fixtures/367.mdx`	`87 B`
`test/fixtures/371.mdx`	`75 B`
`test/fixtures/380.mdx`	`11.0 kB`
`test/fixtures/391.mdx`	`62 B`
`test/fixtures/429.mdx`	`52 B`
`test/fixtures/435.mdx`	`134 B`
`test/fixtures/437.mdx`	`32 B`
`test/fixtures/445.mdx`	`188 B`
`test/fixtures/450.mdx`	`417 B`
`test/fixtures/488.mdx`	`78 B`
`test/fixtures/acorn.mdx`	`860 B`
`test/fixtures/adjacent.mdx`	`50 B`
`test/fixtures/async/.remarkrc`	`67 B`
`test/fixtures/async/test.md`	`15 B`
`test/fixtures/basic.mdx`	`405 B`
`test/fixtures/basic.tsx`	`77 B`
`test/fixtures/blank-lines.mdx`	`768 B`
`test/fixtures/code-blocks/278.md`	`511 B`
`test/fixtures/code-blocks/455.mdx`	`95 B`
`test/fixtures/code-blocks/470.mdx`	`88 B`
`test/fixtures/code-blocks/534.mdx`	`735 B`
`test/fixtures/comments.mdx`	`162 B`
`test/fixtures/details.mdx`	`881 B`
`test/fixtures/dir.mdx/.gitkeep`	`0 B`
`test/fixtures/esm/.remarkrc.mjs`	`103 B`
`test/fixtures/esm/test.md`	`15 B`
`test/fixtures/jsx-in-list.mdx`	`810 B`
`test/fixtures/leading-spaces.mdx`	`42 B`
`test/fixtures/markdown.md`	`5 B`
`test/fixtures/no-unescaped-entities.mdx`	`99 B`
`test/fixtures/no-unused-expressions.mdx`	`90 B`
`test/fixtures/processor.mdx`	`13 B`
`test/fixtures/remark.md`	`171 B`
`test/fixtures/remark.mdx`	`169 B`
`test/fixtures/style/.remarkrc`	`228 B`
`test/fixtures/style/nested.md`	`10 B`
`test/fixtures/style/plugin1.cjs`	`26 B`
`test/fixtures/style/plugin2.mjs`	`24 B`
`test/fixtures/unicorn.jsx`	`119 B`
`test/fixtures/unicorn.mdx`	`118 B`
`test/helpers.test.ts`	`874 B`
`test/helpers.ts`	`954 B`
`test/jest.serializer.cjs`	`347 B`
`test/jest.serializer.d.cts`	`143 B`
`test/jest.serializer.test.ts`	`527 B`
`test/parser.test.ts`	`4.7 kB`
`test/remark.test.ts`	`2.9 kB`
`tsconfig.base.json`	`253 B`
`tsconfig.json`	`213 B`
`tsconfig.lib.json`	`182 B`

_{🤖 This report was automatically generated by pkg-size-action}

fix: take cwd into cache key account

37ad829

follow #571

JounQin requested a review from Copilot May 16, 2025 06:34

JounQin self-assigned this May 16, 2025

JounQin added the 🐛 type/bug This is a problem label May 16, 2025

Copilot AI reviewed May 16, 2025

View reviewed changes

Create grumpy-ads-play.md

30e667c

JounQin added 2 commits May 16, 2025 14:35

Create moody-ladybugs-fold.md

ba0d72e

ci: drop Node 23 test, add Node 24 test

698dfee

JounQin merged commit b670ae4 into master May 16, 2025
55 checks passed

JounQin deleted the fix/cwd branch May 16, 2025 06:44

github-actions bot mentioned this pull request May 16, 2025

chore: release package(s) #578

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: take `cwd` into cache key account #577

fix: take `cwd` into cache key account #577

Uh oh!

JounQin commented May 16, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented May 16, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

codesandbox-ci bot commented May 16, 2025 •

edited

Loading

Uh oh!

codecov bot commented May 16, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 16, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix: take cwd into cache key account #577

fix: take cwd into cache key account #577

Uh oh!

Conversation

JounQin commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Initial checklist

Description of changes

Uh oh!

changeset-bot bot commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

codesandbox-ci bot commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Package size report No changes

Uh oh!

Uh oh!

Uh oh!

fix: take `cwd` into cache key account #577

fix: take `cwd` into cache key account #577

JounQin commented May 16, 2025 •

edited

Loading

changeset-bot bot commented May 16, 2025 •

edited

Loading

codesandbox-ci bot commented May 16, 2025 •

edited

Loading

codecov bot commented May 16, 2025 •

edited

Loading

github-actions bot commented May 16, 2025 •

edited

Loading

📊 Package size report `No changes`