Add support for timestamp in RFC3339 format #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default Go log/syslog is sending syslog messages in that format: https://github.com/golang/go/blob/9745eed4fd4160cfbf55e9dbbfa99aca5563b392/src/log/syslog/syslog.go#L294 That is not according to the standard: "The TIMESTAMP field is the local time and is in the format of "Mmm dd hh:mm:ss" (without the quote marks)" (https://tools.ietf.org/html/rfc3164#section-5.3) But it is necessery if we want to parse lines sent by log/syslog. One small fix, time.Stamp is same as those two formats: - "Jan 02 15:04:05", - "Jan 2 15:04:05", + time.Stamp,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #45.
Default Go log/syslog is sending syslog messages in that format.
That is not according to the standard:
"The TIMESTAMP field is the local time and is in the format of "Mmm dd hh:mm:ss" (without the quote marks)"
But it is necessery if we want to parse lines sent by log/syslog.