Fix a bug in parseUpToLen() for handling given max chars limit. #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parseUpToLen function would not handle the max chars limit. Found when using a syslog client which used > max chars for the APP-NAME. I changed the syslog client to use max chars and it still didn't work. There was an off by 1 error. One of the tests even gave a max chars string and expected an error - changed that test to try with max+1 chars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parseUpToLen function would not handle the max chars limit.
Found when using a syslog client which used > max chars for the
APP-NAME. I changed the syslog client to use max chars and it still
didn't work. There was an off by 1 error. One of the tests even
gave a max chars string and expected an error - changed that test
to try with max+1 chars.