Update cron format docs #365
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taraspos
reviewed
Jul 20, 2025
| c.sh.AddJob(j) | ||
| err = c.sh.AddJob(j) | ||
| if err != nil { | ||
| c.logger.Debugf("Unable to add new exec job %s from config: %v", name, err) |
There was a problem hiding this comment.
Hmmm... the error was supposed to be logged inside AddJob function. Let me try to reproduce this
| @@ -52,7 +52,7 @@ command = touch /tmp/example | |||
|
|
|||
|
|
|||
| [job-service-run "service-executed-on-new-container"] | |||
| schedule = 0,20,40 * * * * | |||
| schedule = 0,20,40 * * * | |||
There was a problem hiding this comment.
This schedule actually had 5 elements, as expected
Suggested change
| schedule = 0,20,40 * * * | |
| schedule = 0,20,40 * * * * |
| ### INI-file example | ||
|
|
||
| ```ini | ||
| [job-service-run "service-executed-on-new-container"] | ||
| schedule = 0,20,40 * * * * | ||
| schedule = 0,20,40 * * * |
There was a problem hiding this comment.
Suggested change
| schedule = 0,20,40 * * * | |
| schedule = 0,20,40 * * * * |
There was a problem hiding this comment.
Good catch, it might make sense to implement some kind of detection of wrong cron format and discard last * for backward compatibility.
There was a problem hiding this comment.
It would probably make sense to do this:
Footnotes
|
Superseded by #366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed that you updated the
cronpackage on the 0.4.0-beta version. Unlike the old cron package robfig/cron/v1 does the new cron package robfig/cron/v3 no longer support seconds in the format.I've also added logs to all instances where new jobs are created since the error produced was not logged anywhere.
closes #351