fix: Don't let concurrenct default to zero. #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the default value for concurrency is `os.availableParallelism() - 1`, which for most system is probably ok, since that function usually returns a value greater than 1. But for those systems that return a value of 1, the default would then be zero, which will cause an OUT_OF_RANGE error later on down the call chain. This fix will make the default value 1 if the `os.availableParallelism() - 1` is zero. This doesn't change anything if the user specifys a 1 for the concurrency flag.
|
hi, just wanted to see if this would be merged soon-ish :) |
|
will release asap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #160
Currently, the default value for concurrency is
os.availableParallelism() - 1, which for most system is probably ok, since that function usually returns a value greater than 1. But for those systems that return a value of 1, the default would then be zero, which will cause an OUT_OF_RANGE error later on down the call chain.This fix will make the default value 1 if the
os.availableParallelism() - 1is zero. This doesn't change anything if the user specifys a 1 for the concurrency flag.