Skip to content

Fix json panic #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2023
Merged

Fix json panic #251

merged 2 commits into from
Oct 27, 2023

Conversation

maxatome
Copy link
Owner

Thanks to @mxpetit for the report.

@maxatome
fix: collecting multiple times the same error leads to panic
be44557 
Typical case:

    td.JSON(`[$1,$1]`, td.Re(123))

Signed-off-by: Maxime Soulé <btik-git@scoubidou.com>
@maxatome
fix(JSON): mixing numeric and named placeholders didn't work correctly
83bafbc 
Signed-off-by: Maxime Soulé <btik-git@scoubidou.com>
@coveralls
Copy link

Coverage Status

coverage: 99.865%. remained the same when pulling 83bafbc on fix-json-panic into 6a1fb6b on master.

@maxatome maxatome merged commit 6250333 into master Oct 27, 2023
@maxatome maxatome deleted the fix-json-panic branch October 27, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@deathiop deathiop deathiop approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxatome @coveralls @deathiop