Skip to content

Add index to puppet custom_mxid column #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2022
Merged

Add index to puppet custom_mxid column #845

merged 2 commits into from
Oct 11, 2022

Conversation

Half-Shot
Copy link
Contributor

We were seeing a huge number of queries for

SELECT id, is_registered, displayname, displayname_source, displayname_contact, displayname_quality, disable_updates, 
username, phone, photo_id, avatar_url, name_set, avatar_set, is_bot, is_channel, custom_mxid, access_token, next_batch, 
base_url FROM puppet WHERE custom_mxid=$1

Which we ended up fixing by adding a unique index. This made our DB CPU graph make a happy face.

image

jaller94
jaller94 reviewed Sep 30, 2022
View reviewed changes
@Half-Shot Half-Shot mentioned this pull request Oct 10, 2022
Closed
@tulir tulir merged commit e053664 into mautrix:master Oct 11, 2022
@AndrewFerr AndrewFerr mentioned this pull request Oct 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tulir tulir tulir approved these changes

+1 more reviewer

@jaller94 jaller94 jaller94 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Half-Shot @tulir @jaller94