Skip to content

Conversation

fedys
Copy link
Member

@fedys fedys commented Jul 29, 2025

Q A
Bug fix? (use the a.b branch)
New feature/enhancement? (use the a.x branch) ✔️
Deprecations?
BC breaks? (use the c.x branch)
Automated tests included? ✔️
Related user documentation PR URL
Related developer documentation PR URL
Issue(s) addressed

Description

This PR introduces JobExtendTimeEvent that can be used in environments that use job queuing backends for extending job time to execute.


📋 Steps to test this PR:

  1. There is nothing to test as the PR does not introduce any new feature or change.
  2. You can quickly test if none of the following features is failing:
    1. Events for campaign members are executed (Campaign kickoff).
    2. CSV exports of contacts.
    3. CSV export of reports.

Copy link

codecov bot commented Jul 29, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.70%. Comparing base (4d0be15) to head (664ae69).
⚠️ Report is 25 commits behind head on 7.x.

Files with missing lines Patch % Lines
...pp/bundles/CoreBundle/Event/JobExtendTimeEvent.php 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                7.x   #15322   +/-   ##
=========================================
  Coverage     66.70%   66.70%           
- Complexity    35847    35849    +2     
=========================================
  Files          2328     2329    +1     
  Lines        144086   144093    +7     
=========================================
+ Hits          96117    96122    +5     
- Misses        47969    47971    +2     
Files with missing lines Coverage Δ
.../CampaignBundle/Executioner/KickoffExecutioner.php 100.00% <100.00%> (ø)
app/bundles/CoreBundle/Helper/ExportHelper.php 99.27% <100.00%> (+<0.01%) ⬆️
app/bundles/ReportBundle/Model/ReportExporter.php 76.19% <100.00%> (+0.58%) ⬆️
...pp/bundles/CoreBundle/Event/JobExtendTimeEvent.php 50.00% <50.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fedys fedys requested review from a team, nileshlohar and rahuld-dev and removed request for a team July 29, 2025 14:12
Copy link

Copy link
Member

@kuzmany kuzmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems good

Copy link
Contributor

@nileshlohar nileshlohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tested on local and it works fine.

@nileshlohar nileshlohar added the unforking Used for PRs in the Acquia's unforking initiative label Aug 1, 2025
@escopecz escopecz added enhancement Any improvement to an existing feature or functionality plugin Anything related to plugins labels Aug 1, 2025
@escopecz escopecz added this to the 7.0.0-alpha milestone Aug 1, 2025
@escopecz escopecz merged commit a85d685 into mautic:7.x Aug 1, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any improvement to an existing feature or functionality plugin Anything related to plugins unforking Used for PRs in the Acquia's unforking initiative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants