Skip to content

Add content block empty states for Projects and improve Category labels #15292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 23, 2025
Merged

Add content block empty states for Projects and improve Category labels #15292

merged 5 commits into from
Jul 23, 2025

Conversation

andersonjeccel
Copy link
Contributor

@andersonjeccel andersonjeccel commented Jul 21, 2025 •
edited
Loading

Q A
Bug fix? (use the a.b branch) ❌
New feature/enhancement? (use the a.x branch) ✔️
Deprecations? ❌
BC breaks? (use the c.x branch) ❌
Automated tests included? ❌
Related user documentation PR URL
Related developer documentation PR URL
Issue(s) addressed

Description

This PR improves the empty state experience for Projects and Categories by implementing content blocks that provide clear guidance to users when no items exist.

Changes Made:

Projects Bundle:

  • Added content block empty state for Projects list when no projects exist and no search is active
  • Used asset-management pictogram for visual representation
  • Added translation strings for heading, subheading, and copy text
  • Conditionally shows content block vs. standard "no results" based on search state
image

Category Bundle:

  • Improved translation labels for category empty state content
  • Refined subheading and copy text to better explain categorization purpose
image

The implementation follows the existing CategoryBundle pattern for consistency and ensures proper internationalization support.

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Navigate to Projects (/s/projects) when no projects exist
  3. Verify content block displays with heading "Turn campaign plans into action"
  4. Perform a search with no results and verify standard "no results" message appears
  5. Navigate to Categories when no categories exist to see improved labels

@andersonjeccel
Improve category empty state content labels
e0e9adb 
- Update subheading to clarify categorization purpose
- Refine copy text to better explain categories as high-level labels
@andersonjeccel
Add content block empty state for projects list
6803ff6 
- Implement empty state with heading, subheading, and copy when no projects exist
- Use asset-management pictogram for visual representation
- Conditionally show content block only when no search is active
- Add translation strings for all content block text
- Match CategoryBundle empty state pattern for consistency
@andersonjeccel andersonjeccel added T1 Low difficulty to fix (issue) or test (PR) user-interface Anything related to appearance, layout, and interactivity ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging enhancement Any improvement to an existing feature or functionality labels Jul 21, 2025
@andersonjeccel andersonjeccel self-assigned this Jul 21, 2025
jos0405
jos0405 approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@jos0405 jos0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, does what is sais.
I also checked it in multiple languages.

image image image image

@jos0405 jos0405 added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels Jul 22, 2025
Bastian2718
Bastian2718 approved these changes Jul 22, 2025
View reviewed changes
Copy link

@Bastian2718 Bastian2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Bastian2718 Bastian2718 added user-testing-passed PRs which have been successfully tested by the required number of people. and removed pending-test-confirmation PR's that require one test before they can be merged labels Jul 22, 2025
RCheesley
RCheesley requested changes Jul 22, 2025
View reviewed changes
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small suggestions here too @andersonjeccel - thanks for the PR!

@github-project-automation github-project-automation bot moved this to 🚨 Developer revision needed in Open Source Fridays Jul 22, 2025
@RCheesley RCheesley added this to the 7.0.0-alpha milestone Jul 22, 2025
@andersonjeccel @RCheesley
Apply suggestions from code review
537d7c2 
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
@andersonjeccel andersonjeccel requested a review from RCheesley July 22, 2025 17:16
@codecov Codecov
Copy link

codecov bot commented Jul 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.64%. Comparing base (554427f) to head (ffe3663).
Report is 6 commits behind head on 7.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                7.x   #15292   +/-   ##
=========================================
  Coverage     66.64%   66.64%           
  Complexity    35046    35046           
=========================================
  Files          2299     2299           
  Lines        141372   141372           
=========================================
  Hits          94221    94221           
  Misses        47151    47151
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

escopecz
escopecz approved these changes Jul 23, 2025
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues in the code changes 👍

@escopecz escopecz added projects Anything related to Projects code-review-passed PRs which have passed code review ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed code-review-needed PR's that require a code review before merging labels Jul 23, 2025
@escopecz
Copy link
Member

@RCheesley can you please re-review? I cannot merge this when you've requested changes.

RCheesley
RCheesley approved these changes Jul 23, 2025
View reviewed changes
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@andersonjeccel andersonjeccel moved this from 🚨 Developer revision needed to 🎉 Ready to commit in Open Source Fridays Jul 23, 2025
@escopecz escopecz merged commit 4647c9d into mautic:7.x Jul 23, 2025
26 checks passed
@github-project-automation github-project-automation bot moved this from 🎉 Ready to commit to 🥳 Done in Open Source Fridays Jul 23, 2025
@andersonjeccel andersonjeccel deleted the content-block-empty-states branch July 23, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

@RCheesley RCheesley RCheesley approved these changes

@jos0405 jos0405 jos0405 approved these changes

+1 more reviewer

@Bastian2718 Bastian2718 Bastian2718 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@andersonjeccel andersonjeccel

Labels
code-review-passed PRs which have passed code review enhancement Any improvement to an existing feature or functionality projects Anything related to Projects ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged T1 Low difficulty to fix (issue) or test (PR) user-interface Anything related to appearance, layout, and interactivity user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
Open Source Fridays
Status: 🥳 Done
Milestone
7.0.0-alpha
Development

Successfully merging this pull request may close these issues.
5 participants
@andersonjeccel @escopecz @RCheesley @jos0405 @Bastian2718