Skip to content

Removing unused deprecations #15284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 21, 2025
Merged

Removing unused deprecations #15284

merged 9 commits into from
Jul 21, 2025

Conversation

escopecz
Copy link
Member

@escopecz escopecz commented Jul 18, 2025 •
edited by RCheesley
Loading

Q A
Bug fix? (use the a.b branch) ❌
New feature/enhancement? (use the a.x branch) ✔️
Deprecations? ✔️
BC breaks? (use the c.x branch) ✔️
Automated tests included? ❌
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

I went through the code searching for the @deprecated label and deleted code that was unused everywhere.

⚠️ Run rm -rf vendor && composer install - with ddev ssh in front if you're using DDEV - to avoid the AppCache.php errors. I couldn't find any simpler way how to do it.

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Click through the UI. The only thing that won't be caught by our tests will be the removed JS functions for map handling. So check the map on the contact detail or the map dashboard widget is still working.

@escopecz escopecz force-pushed the bye-bye-deprecations branch 3 times, most recently from 0167d01 to 7484412 Compare July 18, 2025 16:01
@escopecz escopecz force-pushed the bye-bye-deprecations branch from 7484412 to c7d8890 Compare July 18, 2025 16:10
@escopecz escopecz requested a review from Copilot July 21, 2025 07:44
Copilot
Copilot AI reviewed Jul 21, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@codecov Codecov
Copy link

codecov bot commented Jul 21, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.63%. Comparing base (7fadd03) to head (66ff7e6).
⚠️ Report is 448 commits behind head on 7.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                7.x   #15284      +/-   ##
============================================
+ Coverage     66.41%   66.63%   +0.21%     
+ Complexity    35210    35036     -174     
============================================
  Files          2319     2299      -20     
  Lines        141913   141313     -600     
============================================
- Hits          94257    94162      -95     
+ Misses        47656    47151     -505
Files with missing lines Coverage Δ
...es/CampaignBundle/Executioner/EventExecutioner.php 81.04% <ø> (+2.86%) ⬆️
...ignBundle/Executioner/Scheduler/EventScheduler.php 84.81% <ø> (+1.58%) ⬆️
.../bundles/ChannelBundle/Model/MessageQueueModel.php 91.02% <ø> (+1.71%) ⬆️
...bundles/CoreBundle/Controller/CommonController.php 85.36% <ø> (+0.88%) ⬆️
...p/bundles/CoreBundle/Controller/FormController.php 100.00% <ø> (ø)
...reBundle/Doctrine/Mapping/ClassMetadataBuilder.php 97.80% <ø> (+1.06%) ⬆️
app/bundles/CoreBundle/Entity/Cache.php 59.18% <ø> (ø)
...p/bundles/CoreBundle/Helper/BuilderTokenHelper.php 76.08% <ø> (+7.45%) ⬆️
...undles/DashboardBundle/Event/WidgetDetailEvent.php 70.83% <ø> (+1.16%) ⬆️
app/bundles/EmailBundle/Entity/EmailRepository.php 88.75% <ø> (+2.29%) ⬆️
... and 22 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@escopecz escopecz added code-review-needed PR's that require a code review before merging deprecation Includes deprecations refactoring The change does not change behavior but improves the code labels Jul 21, 2025
@escopecz escopecz marked this pull request as ready for review July 21, 2025 11:27
@escopecz escopecz added this to the 7.0.0-alpha milestone Jul 21, 2025
RCheesley
RCheesley approved these changes Jul 21, 2025
View reviewed changes
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the map widget on the homepage and checked all the date filters which seems to be working as expected. The contact map on the user profile is also working fine, checked highlighting, zooming etc.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@escopecz escopecz requested a review from matbcvo July 21, 2025 12:08
matbcvo
matbcvo approved these changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@matbcvo matbcvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me. I tested the PR and found no issues.👍Thanks!

@matbcvo matbcvo added code-review-passed PRs which have passed code review and removed code-review-needed PR's that require a code review before merging labels Jul 21, 2025
@escopecz escopecz added the user-testing-passed PRs which have been successfully tested by the required number of people. label Jul 21, 2025
@matbcvo matbcvo added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed user-testing-passed PRs which have been successfully tested by the required number of people. labels Jul 21, 2025
@escopecz escopecz merged commit 8b59a07 into mautic:7.x Jul 21, 2025
27 checks passed
@matbcvo matbcvo added the user-testing-passed PRs which have been successfully tested by the required number of people. label Jul 21, 2025
@escopecz escopecz added the enhancement Any improvement to an existing feature or functionality label Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@matbcvo matbcvo matbcvo approved these changes

@RCheesley RCheesley RCheesley approved these changes

Assignees
No one assigned
Labels
code-review-passed PRs which have passed code review deprecation Includes deprecations enhancement Any improvement to an existing feature or functionality ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged refactoring The change does not change behavior but improves the code user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
None yet
Milestone
7.0.0-alpha
Development

Successfully merging this pull request may close these issues.
3 participants
@escopecz @matbcvo @RCheesley