Skip to content

Fix PHP 8.4 deprecations #15280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jul 18, 2025
Merged

Fix PHP 8.4 deprecations #15280

merged 19 commits into from
Jul 18, 2025

Conversation

matbcvo
Copy link
Contributor

@matbcvo matbcvo commented Jul 18, 2025 •
edited
Loading

Q A
Bug fix? (use the a.b branch) ✔️❌
New feature/enhancement? (use the a.x branch) ✔️❌
Deprecations? ✔️❌
BC breaks? (use the c.x branch) ✔️❌
Automated tests included? ✔️❌
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

I initially tried upgrading all packages at once, but that resulted in too many errors and failing tests. I switched to upgrading packages individually, resolving related deprecations and issues step by step, by identifying which package caused a deprecation and upgrading it accordingly.

  - Upgrading guzzlehttp/guzzle (7.8.1 => 7.9.3)
  - Upgrading guzzlehttp/promises (2.0.2 => 2.2.0)
  - Upgrading exercise/htmlpurifier-bundle (5.0 => 5.1)
  - Upgrading javer/lightsaml (v1.8.0 => 1.9.0)
  - Upgrading liip/test-fixtures-bundle (2.10.0 => 3.5.0)
  - Upgrading doctrine/data-fixtures (1.7.0 => 1.8.2)
  - Upgrading simshaun/recurr (v5.0.2 => v5.0.3)
  - Upgrading helios-ag/fm-elfinder-bundle (12.5 => 12.7.3)
  - Upgrading bjeavons/zxcvbn-php (1.3.1 => 1.4.2)
  - Upgrading league/flysystem-local (3.23.1 => 3.30.0)
  - Upgrading jms/serializer (3.29.1 => 3.32.5)
  - Upgrading jms/serializer-bundle (5.4.0 => 5.5.1)
  - Upgrading league/mime-type-detection (1.15.0 => 1.16.0)
  - Upgrading league/flysystem (3.24.0 => 3.30.0)
  - Upgrading wikimedia/less.php (v4.4.1 => v5.4.0)
  - Upgrading kamermans/guzzle-oauth2-subscriber (v1.0.13 => v1.1.1)

The predis/predis package still needs to be upgraded, but that requires refactoring due to breaking changes. It will be handled in a separate PR. For now, deprecations related to Predis remain.

twig/twig v4, which is not yet released, resolves the deprecations related to non-static data providers in integration tests. Since addressing them now would require workarounds or overriding internal behavior, this PR does not fix the deprecations.

📋 Steps to test this PR:

  1. Check that all automated tests pass (CI green)
  2. Check that PHPUnit tests (PHP 8.4) run without deprecations, except for the ones related to TwigIntegrationTest and Predis.

@matbcvo matbcvo changed the title Update Composer dependencies to fix PHP 8.4 deprecations Fix PHP 8.4 deprecations Jul 18, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.41%. Comparing base (4a5fe46) to head (708373c).
Report is 18 commits behind head on 7.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                7.x   #15280   +/-   ##
=========================================
  Coverage     66.40%   66.41%           
- Complexity    35205    35210    +5     
=========================================
  Files          2318     2319    +1     
  Lines        141895   141913   +18     
=========================================
+ Hits          94231    94257   +26     
+ Misses        47664    47656    -8

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matbcvo matbcvo force-pushed the update-packages-v2 branch 2 times, most recently from a1a2d41 to ea46b6f Compare July 18, 2025 13:54
@matbcvo
Copy link
Contributor Author

matbcvo commented Jul 18, 2025

This predis/predis package needs to be upgraded, but it requires refactoring due to breaking changes. This should be done in a separate PR.

@matbcvo matbcvo force-pushed the update-packages-v2 branch 4 times, most recently from 247c1ea to 54e6685 Compare July 18, 2025 15:26
@matbcvo matbcvo marked this pull request as ready for review July 18, 2025 15:38
@matbcvo matbcvo added the dependencies Pull requests that update a dependency file label Jul 18, 2025
@matbcvo matbcvo added composer Any bugs or PRs relating to composer code-review-needed PR's that require a code review before merging enhancement Any improvement to an existing feature or functionality labels Jul 18, 2025
@matbcvo matbcvo added this to the 7.0.0-alpha milestone Jul 18, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matbcvo matbcvo requested a review from escopecz July 18, 2025 15:40
escopecz
escopecz approved these changes Jul 18, 2025
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! The list of deprecations bellow the PHP 8.4 test results is way, way smaller. Thank you! 👍

@escopecz escopecz added code-review-passed PRs which have passed code review and removed code-review-needed PR's that require a code review before merging labels Jul 18, 2025
@escopecz escopecz merged commit 9dade54 into mautic:7.x Jul 18, 2025
25 checks passed
@matbcvo matbcvo deleted the update-packages-v2 branch July 18, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
code-review-passed PRs which have passed code review composer Any bugs or PRs relating to composer dependencies Pull requests that update a dependency file enhancement Any improvement to an existing feature or functionality
Projects
None yet
Milestone
7.0.0-alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@matbcvo @escopecz