Skip to content

Update klapaudius/oauth-server-bundle and klapaudius/oauth2-php packages #15279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2025
Merged

Update klapaudius/oauth-server-bundle and klapaudius/oauth2-php packages #15279

merged 1 commit into from
Jul 18, 2025

Conversation

matbcvo
Copy link
Contributor

@matbcvo matbcvo commented Jul 18, 2025 •
edited
Loading

Q A
Bug fix? (use the a.b branch) ✔️❌
New feature/enhancement? (use the a.x branch) ✔️❌
Deprecations? ✔️❌
BC breaks? (use the c.x branch) ✔️❌
Automated tests included? ✔️❌
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

Ran composer update klapaudius/oauth-server-bundle klapaudius/oauth2-php to bring the following packages up to date:

Loading composer repositories with package information
Updating dependencies                                 
Lock file operations: 0 installs, 2 updates, 0 removals
  - Upgrading klapaudius/oauth-server-bundle (5.1.1 => 5.1.2)
  - Upgrading klapaudius/oauth2-php (1.6.0 => 1.8.0)

The update to oauth2-php v1.8.0 fixes PHP 8.4 deprecation notices seen in the tests:

PHP Deprecated:  OAuth2\OAuth2::getBearerToken(): Implicitly marking parameter $request as nullable is deprecated, the explicit nullable type must be used instead in /home/runner/work/mautic/mautic/vendor/klapaudius/oauth2-php/lib/OAuth2.php on line 491
PHP Deprecated:  OAuth2\OAuth2::grantAccessToken(): Implicitly marking parameter $request as nullable is deprecated, the explicit nullable type must be used instead in /home/runner/work/mautic/mautic/vendor/klapaudius/oauth2-php/lib/OAuth2.php on line 684
PHP Deprecated:  OAuth2\OAuth2::getAuthorizeParams(): Implicitly marking parameter $request as nullable is deprecated, the explicit nullable type must be used instead in /home/runner/work/mautic/mautic/vendor/klapaudius/oauth2-php/lib/OAuth2.php on line 1017
PHP Deprecated:  OAuth2\OAuth2::finishClientAuthorization(): Implicitly marking parameter $request as nullable is deprecated, the explicit nullable type must be used instead in /home/runner/work/mautic/mautic/vendor/klapaudius/oauth2-php/lib/OAuth2.php on line 1129
PHP Deprecated:  OAuth2\IOAuth2::getBearerToken(): Implicitly marking parameter $request as nullable is deprecated, the explicit nullable type must be used instead in /home/runner/work/mautic/mautic/vendor/klapaudius/oauth2-php/lib/IOAuth2.php on line 88
PHP Deprecated:  OAuth2\IOAuth2::grantAccessToken(): Implicitly marking parameter $request as nullable is deprecated, the explicit nullable type must be used instead in /home/runner/work/mautic/mautic/vendor/klapaudius/oauth2-php/lib/IOAuth2.php on line 108
PHP Deprecated:  OAuth2\IOAuth2::finishClientAuthorization(): Implicitly marking parameter $request as nullable is deprecated, the explicit nullable type must be used instead in /home/runner/work/mautic/mautic/vendor/klapaudius/oauth2-php/lib/IOAuth2.php on line 128

📋 Steps to test this PR:

  1. Check that all automated tests pass (CI green)
  2. Check that PHPUnit tests (PHP 8.4) runs without deprecation notices related to OAuth2 in CI logs

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matbcvo matbcvo added composer Any bugs or PRs relating to composer dependencies Pull requests that update a dependency file labels Jul 18, 2025
@matbcvo matbcvo marked this pull request as ready for review July 18, 2025 11:00
@matbcvo matbcvo added this to the 7.0.0-alpha milestone Jul 18, 2025
@matbcvo matbcvo requested a review from escopecz July 18, 2025 11:03
escopecz
escopecz approved these changes Jul 18, 2025
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I see no deprecation notices coming from this library anymore in the PHP 8.4 test suite results 👍

@escopecz escopecz merged commit 4a5fe46 into mautic:7.x Jul 18, 2025
38 of 48 checks passed
@escopecz escopecz added the enhancement Any improvement to an existing feature or functionality label Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
composer Any bugs or PRs relating to composer dependencies Pull requests that update a dependency file enhancement Any improvement to an existing feature or functionality
Projects
None yet
Milestone
7.0.0-alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@matbcvo @escopecz