Skip to content

Add outline to builder button #15277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 18, 2025
Merged

Add outline to builder button #15277

merged 3 commits into from
Jul 18, 2025

Conversation

PatrickJenkner
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) ❌
New feature/enhancement? (use the a.x branch) ✔️
Deprecations? ❌
BC breaks? (use the c.x branch) ❌
Automated tests included? ❌
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #15218

Description

The button to launch the builder for campaigns, emails, focus items and landing pages currently uses the "ghost" style, causing it to have the same color as the background without a border. This makes it harder to spot the button.

This PR changes the button to use the "tertiary" style, giving it an outline:

image

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Create a new campaign and see the changed button
  3. Repeat for emails
  4. Repeat for focus items
  5. Repeat for landing page

@PatrickJenkner
Copy link
Contributor Author

FYI: There are other places that have the same issue, e.g. the button to select an email theme. I will create separate PRs for these if this one gets accepted

@PatrickJenkner PatrickJenkner added user-interface Anything related to appearance, layout, and interactivity ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging accessibility Any issues relating to accessibility labels Jul 18, 2025
@escopecz
Copy link
Member

@PatrickJenkner thanks for this PR! Do you want to address the other places in this PR or different ones?

@escopecz escopecz requested a review from andersonjeccel July 18, 2025 12:12
@codecov Codecov
Copy link

codecov bot commented Jul 18, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.41%. Comparing base (9419b5c) to head (99b869a).
⚠️ Report is 474 commits behind head on 7.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                7.x   #15277   +/-   ##
=========================================
  Coverage     66.41%   66.41%           
  Complexity    35210    35210           
=========================================
  Files          2319     2319           
  Lines        141913   141913           
=========================================
  Hits          94257    94257           
  Misses        47656    47656
Files with missing lines Coverage Δ
.../bundles/CampaignBundle/Form/Type/CampaignType.php 97.50% <100.00%> (ø)
app/bundles/EmailBundle/Form/Type/EmailType.php 98.16% <100.00%> (ø)
app/bundles/PageBundle/Form/Type/PageType.php 97.33% <100.00%> (ø)
plugins/MauticFocusBundle/Form/Type/FocusType.php 90.21% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PatrickJenkner
Copy link
Contributor Author

PatrickJenkner commented Jul 18, 2025 •
edited
Loading

@escopecz I will create different PRs for each type of button/for each place where buttons should be changed. That way it's easier to discuss whether maybe some of them should stay how they are, be changed to a whole other type of button etc.

@PatrickJenkner PatrickJenkner moved this to 🦸🏻 Needs 2 tests in Open Source Fridays Jul 18, 2025
@Bastian2718
Copy link

LGTM!

@escopecz escopecz self-requested a review July 18, 2025 13:16
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

escopecz
escopecz approved these changes Jul 18, 2025
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:

Image

After:

Image

It looks more like a button 👍

@escopecz escopecz added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged code-review-passed PRs which have passed code review user-testing-passed PRs which have been successfully tested by the required number of people. and removed ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging labels Jul 18, 2025
@escopecz escopecz added this to the 7.0.0-alpha milestone Jul 18, 2025
@escopecz escopecz merged commit f498c35 into mautic:7.x Jul 18, 2025
26 checks passed
@github-project-automation github-project-automation bot moved this from 🦸🏻 Needs 2 tests to 🥳 Done in Open Source Fridays Jul 18, 2025
@escopecz escopecz added the enhancement Any improvement to an existing feature or functionality label Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

@andersonjeccel andersonjeccel Awaiting requested review from andersonjeccel

+1 more reviewer

@Bastian2718 Bastian2718 Bastian2718 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
accessibility Any issues relating to accessibility code-review-passed PRs which have passed code review enhancement Any improvement to an existing feature or functionality ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged user-interface Anything related to appearance, layout, and interactivity user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
Open Source Fridays
Status: 🥳 Done
Milestone
7.0.0-alpha
Development

Successfully merging this pull request may close these issues.

Button for builder has the same color as the background
3 participants
@PatrickJenkner @escopecz @Bastian2718