Skip to content

Symfony 7.3 #15268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 17, 2025
Merged

Symfony 7.3 #15268

merged 4 commits into from
Jul 17, 2025

Conversation

matbcvo
Copy link
Contributor

@matbcvo matbcvo commented Jul 17, 2025 •
edited
Loading

Q A
Bug fix? (use the a.b branch) ❌
New feature/enhancement? (use the a.x branch) ✔️
Deprecations? ❌
BC breaks? (use the c.x branch) ❌
Automated tests included? ❌
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

This PR updates the Symfony version constraints in composer.json and app/composer.json from ^7.2 to ^7.3.

composer.json

Package Old Version New Version
symfony/browser-kit ^7.2.0 ^7.3
symfony/dom-crawler ^7.2.0 ^7.3
symfony/maker-bundle ^1.38 ^1.64
symfony/phpunit-bridge ^7.2.0 ^7.3
symfony/var-dumper ^7.2.0 ^7.3
symfony/web-profiler-bundle ^7.2.0 ^7.3

app/composer.json

Package Old Version New Version
symfony/console ^7.2 ^7.3
symfony/form ^7.2 ^7.3
symfony/intl ^7.2 ^7.3
symfony/messenger ^7.2 ^7.3
symfony/options-resolver ^7.2 ^7.3
symfony/process ^7.2 ^7.3
symfony/translation ^7.2 ^7.3
symfony/validator ^7.2 ^7.3
symfony/property-access ^7.2 ^7.3
symfony/cache ^7.2 ^7.3
symfony/asset ^7.2 ^7.3
symfony/dependency-injection ^7.2 ^7.3
symfony/config ^7.2 ^7.3
symfony/event-dispatcher ^7.2 ^7.3
symfony/finder ^7.2 ^7.3
symfony/http-foundation ^7.2 ^7.3
symfony/http-kernel ^7.2 ^7.3
symfony/filesystem ^7.2 ^7.3
symfony/routing ^7.2 ^7.3
symfony/security-core ^7.2 ^7.3
symfony/security-csrf ^7.2 ^7.3
symfony/stopwatch ^7.2 ^7.3
symfony/dotenv ^7.2 ^7.3
symfony/expression-language ^7.2 ^7.3
symfony/framework-bundle ^7.2 ^7.3
symfony/security-bundle ^7.2 ^7.3
symfony/twig-bundle ^7.2 ^7.3
symfony/doctrine-bridge ^7.2 ^7.3
symfony/http-client ^7.2 ^7.3
symfony/lock ^7.2 ^7.3
symfony/doctrine-messenger ^7.2 ^7.3
symfony/mailer ^7.2 ^7.3
symfony/mime ^7.2 ^7.3
symfony/serializer ^7.2 ^7.3

Other Symfony packages like symfony/monolog-bundle (~3.10.0) and symfony/monolog-bridge (^6.4) were not changed.

Additionally, the require section have been sorted alphabetically using Composer's sort-packages option for consistency and readability.

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)

@matbcvo matbcvo marked this pull request as ready for review July 17, 2025 13:18
@matbcvo matbcvo added this to the 7.0.0-alpha milestone Jul 17, 2025
@matbcvo matbcvo added dependencies Pull requests that update a dependency file enhancement Any improvement to an existing feature or functionality labels Jul 17, 2025
@matbcvo
Copy link
Contributor Author

matbcvo commented Jul 17, 2025 •
edited
Loading

Package bandwidth-throttle/token-bucket is blocking the upgrade to symfony/monolog-bridge 7.3 because it requires malkusch/lock ^1, which only supports psr/log ^1. Symfony 7.3 requires monolog/monolog ^3, which in turn requires psr/log ^3.

There is currently no newer version of bandwidth-throttle/token-bucket that supports psr/log ^3, so we need to keep symfony/monolog-bridge pinned to ^6.4 for now.

mautic/app/composer.json

Line 87 in 761f3ac

"bandwidth-throttle/token-bucket": "^2.0",

https://packagist.org/packages/bandwidth-throttle/token-bucket

@matbcvo matbcvo requested a review from escopecz July 17, 2025 13:48
escopecz
escopecz requested changes Jul 17, 2025
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for taking care of that!

Please check also the composer.json in the root dir. I forgot last time there are also some Symfony packages.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matbcvo
Copy link
Contributor Author

matbcvo commented Jul 17, 2025 •
edited
Loading

@escopecz, is the package bandwidth-throttle/token-bucket actually used? I couldn’t find any references to it. Perhaps we can remove it if it’s no longer in use? That might help unblock upgrading symfony/monolog-bridge to 7.3.

@escopecz
Copy link
Member

@matbcvo I don't see usage of that either. Please create a new PR for removal and document the BC break in the upgrading doc.

escopecz
escopecz approved these changes Jul 17, 2025
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this! 👍

I can see I didn't do a great job in the PHP 8.4 PR to upgrade all libraries that are generating deprecation notices. We still have to address those at some point. But it's not blocking this PR.

@escopecz escopecz merged commit 89cd36f into mautic:7.x Jul 17, 2025
27 checks passed
@escopecz escopecz added the code-review-passed PRs which have passed code review label Jul 17, 2025
@matbcvo matbcvo deleted the symfony-7.3 branch July 17, 2025 15:15
@matbcvo matbcvo mentioned this pull request Jul 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
code-review-passed PRs which have passed code review dependencies Pull requests that update a dependency file enhancement Any improvement to an existing feature or functionality
Projects
None yet
Milestone
7.0.0-alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@matbcvo @escopecz