Skip to content

Command for delete anonymous contact from campaigns and segments #15198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 21, 2025
Merged

Command for delete anonymous contact from campaigns and segments #15198

merged 3 commits into from
Jul 21, 2025

Conversation

dadarya0
Copy link
Contributor

@dadarya0 dadarya0 commented Jul 9, 2025 •
edited by escopecz
Loading

Q A
Bug fix? (use the a.b branch) ❌
New feature/enhancement? (use the a.x branch) ✔️
Deprecations? ❌
BC breaks? (use the c.x branch) ❌
Automated tests included? ✔️
Related user documentation PR URL mautic/user-documentation#412
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

Added command to remove all anonymous contacts from Segment and Campaign.

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Check if you have anonymous contact associated with segment or campaign or campaign lead events log
  3. Execute command mautic:remove:anonymous_contacts
  4. All linking of anonymous contact with segment or campaign or campaign lead events log should be deleted now.

dadarya0 and others added 2 commits July 9, 2025 16:24
@dadarya0
Merge pull request mautic#1727 from acquia/MAUT-7042
f9cf5b8 
MAUT-7042 : Add command for delete anonymous contact
@dadarya0
php 8 changes
64236ac
@codecov Codecov
Copy link

codecov bot commented Jul 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.64%. Comparing base (8b59a07) to head (8053c48).
Report is 6 commits behind head on 7.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                7.x   #15198      +/-   ##
============================================
+ Coverage     66.63%   66.64%   +0.01%     
- Complexity    35037    35046       +9     
============================================
  Files          2299     2300       +1     
  Lines        141315   141364      +49     
============================================
+ Hits          94161    94210      +49     
  Misses        47154    47154
Files with missing lines Coverage Δ
...s/CampaignBundle/Entity/LeadEventLogRepository.php 87.72% <100.00%> (+0.38%) ⬆️
...p/bundles/CampaignBundle/Entity/LeadRepository.php 76.30% <100.00%> (+0.73%) ⬆️
...eBundle/Command/RemoveAnonymousContactsCommand.php 100.00% <100.00%> (ø)
...p/bundles/LeadBundle/Entity/ListLeadRepository.php 82.22% <100.00%> (+6.46%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@escopecz escopecz changed the title Command for delete anonymous contact Command for delete anonymous contact from campaigns and segments Jul 11, 2025
kuzmany
kuzmany approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@kuzmany kuzmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@dadarya0 dadarya0 added the unforking Used for PRs in the Acquia's unforking initiative label Jul 15, 2025
@dadarya0 dadarya0 requested a review from rahuld-dev July 15, 2025 05:00
escopecz
escopecz approved these changes Jul 21, 2025
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found in the code 👍

@escopecz escopecz added enhancement Any improvement to an existing feature or functionality code-review-passed PRs which have passed code review user-testing-passed PRs which have been successfully tested by the required number of people. labels Jul 21, 2025
@escopecz escopecz mentioned this pull request Jul 21, 2025
Open
@escopecz escopecz added this to the 7.0.0-alpha milestone Jul 21, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
14.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@escopecz escopecz merged commit c69b5d7 into mautic:7.x Jul 21, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuzmany kuzmany kuzmany approved these changes

@escopecz escopecz escopecz approved these changes

@rahuld-dev rahuld-dev Awaiting requested review from rahuld-dev

Assignees
No one assigned
Labels
code-review-passed PRs which have passed code review enhancement Any improvement to an existing feature or functionality unforking Used for PRs in the Acquia's unforking initiative user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
None yet
Milestone
7.0.0-alpha
Development

Successfully merging this pull request may close these issues.
3 participants
@dadarya0 @kuzmany @escopecz