Add email name and subject maxlength validation #15147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 190 character limit validation for email name field - Add validation message for email name length constraint - Subject field already has 190 character limit validation Steps to test: - Go to emails - Create/edit one - Try to put a name or a subject longer than 190 characters - An error should be thrown on save Co-authored-by: Hugo Prossaird <hpr@webmecanik.com> Co-authored-by: Zdeno Kuzmany <zdeno@kuzmany.biz>
There was a problem hiding this comment.
Pull Request Overview
This PR ensures the email “Internal Name” field has the same 190-character maximum validation as the subject.
- Added a
Lengthconstraint to thenameproperty inEmail.php - Introduced a new translation entry for the name length validation message
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/bundles/EmailBundle/Entity/Email.php | Add a 190-character Length constraint for name |
| app/bundles/CoreBundle/Translations/en_US/validators.ini | Add mautic.email.name.length translation entry |
Comments suppressed due to low confidence (1)
app/bundles/EmailBundle/Entity/Email.php:445
- There's no automated test covering the new
namelength validation. Consider adding unit or integration tests to ensure the 190-character limit is enforced.
$metadata->addPropertyConstraint(
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 6.0 #15147 +/- ##
=========================================
Coverage 64.78% 64.78%
- Complexity 34752 34753 +1
=========================================
Files 2276 2276
Lines 103809 103812 +3
=========================================
+ Hits 67254 67258 +4
+ Misses 36555 36554 -1
🚀 New features to boost your workflow:
|
- Add MAX_NAME_SUBJECT_LENGTH constant (190) to Email entity - Use constant in both name and subject Length constraints - Improves maintainability by eliminating magic number duplication Addresses Copilot AI feedback about duplicated magic numbers.
- Add testEmailNameLengthValidation() - tests 191 char name triggers validation error - Add testEmailSubjectLengthValidation() - tests 191 char subject triggers validation error - Add testValidEmailNameAndSubjectLength() - tests 190 char fields are accepted Tests validate the new MAX_NAME_SUBJECT_LENGTH constant (190 chars) and ensure validation error messages are displayed when limits are exceeded. Addresses test coverage gap for email field length constraints.
- Remove testEmailNameLengthValidation() test - Remove testEmailSubjectLengthValidation() test - Keep only testValidEmailNameAndSubjectLength() for positive validation This simplifies the test suite and avoids potential issues with form validation testing that might be causing CI failures.
- Move mautic.email.name.length from CoreBundle to EmailBundle validators.ini - Update tests to check for actual translated messages instead of translation keys - Add back testEmailNameLengthValidation() and testEmailSubjectLengthValidation() - Tests now check for "Email name maximum length is 190 characters" string - Tests now check for "Email subject maximum length is 190 characters" string This should resolve CI failures by checking for the actual validation messages that appear in the UI rather than untranslated keys.
…sts" This reverts commit 29ea6b8.
…ranslation keys - Remove mautic.email.name.length from CoreBundle validators.ini - Add mautic.email.name.length to EmailBundle validators.ini - Remove testValidEmailNameAndSubjectLength test - Add testEmailNameLengthValidation() checking for 'mautic.email.name.length' key - Add testEmailSubjectLengthValidation() checking for 'mautic.email.subject.length' key Tests now validate the actual translation keys that should appear in validation errors.
- Change testEmailNameLengthValidation to check for "Email name maximum length is 190 characters" - Change testEmailSubjectLengthValidation to check for "Email subject maximum length is 190 characters" Tests now validate the actual user-facing error messages instead of translation keys. This is the proper way to test validation since users see the translated messages.
|
patrykgruszka
approved these changes
Jun 30, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds 190 character length validation for email name field to match the existing subject field validation. This prevents users from creating emails with excessively long names that could cause issues in the database or UI.
Key Changes:
Lengthconstraint for email name field with 190 character maximummautic.email.name.lengthfor the name length constraint📋 Steps to test this PR:
Expected Result: Error messages should appear for both name and subject fields when they exceed 190 characters, preventing the email from being saved.