Skip to content

Fix plugin SSO authentication response processing when user is authenticated #15020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 19, 2025
Merged

Fix plugin SSO authentication response processing when user is authenticated #15020

merged 2 commits into from
Jun 19, 2025

Conversation

biozshock
Copy link
Contributor

@biozshock biozshock commented May 21, 2025 •
edited
Loading

Q A
Bug fix? (use the a.b branch) ✔️
New feature/enhancement? (use the a.x branch) ❌
Deprecations? ❌
BC breaks? (use the c.x branch) ❌
Automated tests included? ✔️

Description

If the plugin sets the isAuthenticated - properly process the authentication.

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. You can check the fix with the https://github.com/Leuchtfeuer/auth0-for-mautic/tree/Mautic6-Support

@biozshock biozshock mentioned this pull request May 21, 2025
Closed
@codecov Codecov
Copy link

codecov bot commented May 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Project coverage is 64.78%. Comparing base (cc73de5) to head (6284014).
Report is 3 commits behind head on 6.0.

Files with missing lines Patch % Lines
...les/CoreBundle/EventListener/ExceptionListener.php 25.00% 3 Missing ⚠️
...dle/Security/Authenticator/PluginAuthenticator.php 81.81% 2 Missing ⚠️
...hentication/Token/Permissions/TokenPermissions.php 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                6.0   #15020      +/-   ##
============================================
- Coverage     64.78%   64.78%   -0.01%     
- Complexity    34745    34752       +7     
============================================
  Files          2276     2276              
  Lines        103796   103809      +13     
============================================
+ Hits          67248    67255       +7     
- Misses        36548    36554       +6
Files with missing lines Coverage Δ
...hentication/Token/Permissions/TokenPermissions.php 78.37% <50.00%> (-1.63%) ⬇️
...dle/Security/Authenticator/PluginAuthenticator.php 92.50% <81.81%> (-2.03%) ⬇️
...les/CoreBundle/EventListener/ExceptionListener.php 41.66% <25.00%> (-2.09%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@escopecz escopecz added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging plugin Anything related to plugins authentication labels May 21, 2025
@biozshock biozshock force-pushed the plugin-auth-fix branch 2 times, most recently from f5a792f to c171ed3 Compare May 21, 2025 21:34
oltmanns-leuchtfeuer
oltmanns-leuchtfeuer approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@oltmanns-leuchtfeuer oltmanns-leuchtfeuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR as it is needed to use Auth0 in M6 - made the plugin work so lgmt.

@oltmanns-leuchtfeuer oltmanns-leuchtfeuer added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels May 23, 2025
@RCheesley RCheesley moved this to ⏳︎ Needs 1 more test in Open Source Fridays Jun 17, 2025
@kuzmany kuzmany added code-review-passed PRs which have passed code review and removed code-review-needed PR's that require a code review before merging pending-test-confirmation PR's that require one test before they can be merged labels Jun 19, 2025
kuzmany
kuzmany approved these changes Jun 19, 2025
View reviewed changes
Copy link
Member

@kuzmany kuzmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me 👍

@kuzmany kuzmany merged commit 784a712 into mautic:6.0 Jun 19, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from ⏳︎ Needs 1 more test to 🥳 Done in Open Source Fridays Jun 19, 2025
@kuzmany kuzmany added this to the 6.0.3 milestone Jun 19, 2025
@kuzmany kuzmany changed the title Response from plugin SSO authenticator should be properly processed if plugin sets authenticated. Fix plugin SSO authentication response processing when user is authenticated Jun 19, 2025
@driskell
Copy link
Contributor

It works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuzmany kuzmany kuzmany approved these changes

+1 more reviewer

@oltmanns-leuchtfeuer oltmanns-leuchtfeuer oltmanns-leuchtfeuer approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
authentication bug Issues or PR's relating to bugs code-review-passed PRs which have passed code review plugin Anything related to plugins
Projects
Open Source Fridays
Status: 🥳 Done
Milestone
6.0.3
Development

Successfully merging this pull request may close these issues.
5 participants
@biozshock @driskell @kuzmany @oltmanns-leuchtfeuer @escopecz