Skip to content

Fix locale dropdown values being reversed in forms #15096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2025
Merged

Fix locale dropdown values being reversed in forms #15096

merged 2 commits into from
Jun 16, 2025

Conversation

biozshock
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) ✔️
New feature/enhancement? (use the a.x branch) ❌
Deprecations? ❌
BC breaks? (use the c.x branch) ❌
Automated tests included? ✔️
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #12851

Description

The PR fixes the issue with flipped locale field in Form.

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Refer to the linked issue for test steps.
  3. Check other locale fields in Mautic to be sure those are proper.

@RCheesley RCheesley linked an issue Jun 13, 2025 that may be closed by this pull request
Mapped field to locale results in label and code swapped #12851
Closed
1 task
@RCheesley RCheesley added T1 Low difficulty to fix (issue) or test (PR) bug Issues or PR's relating to bugs forms Anything related to forms ready-to-test PR's that are ready to test labels Jun 13, 2025
@RCheesley RCheesley moved this to 🦸🏻 Needs 2 tests in Open Source Fridays Jun 13, 2025
@RCheesley RCheesley added this to the 5.2.7 milestone Jun 13, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.70%. Comparing base (749e69b) to head (6c2a360).
Report is 3 commits behind head on 5.2.

Files with missing lines Patch % Lines
...s/LeadBundle/Twig/Extension/FormFieldExtension.php 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                5.2   #15096      +/-   ##
============================================
- Coverage     63.70%   63.70%   -0.01%     
- Complexity    34682    34683       +1     
============================================
  Files          2274     2274              
  Lines        103766   103768       +2     
============================================
  Hits          66106    66106              
- Misses        37660    37662       +2
Files with missing lines Coverage Δ
...s/LeadBundle/Twig/Extension/FormFieldExtension.php 75.00% <33.33%> (-25.00%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

escopecz
escopecz approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RCheesley was asking for this for years. Ruth, do you think you could give this a test?

It makes sense from the code perspective. I'd merge it more confidently if there would be a test for it.

RCheesley
RCheesley approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IT WORKS!

Hurrah! 🚀

Screenshot 2025-06-16 at 10 10 04

@RCheesley RCheesley added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged code-review-passed PRs which have passed code review and removed ready-to-test PR's that are ready to test labels Jun 16, 2025
@RCheesley RCheesley moved this from 🦸🏻 Needs 2 tests to 🎉 Ready to commit in Open Source Fridays Jun 16, 2025
@escopecz escopecz merged commit 82e71b6 into mautic:5.2 Jun 16, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from 🎉 Ready to commit to 🥳 Done in Open Source Fridays Jun 16, 2025
@kuzmany kuzmany changed the title Swap key value pairs for locale Form field. Fix locale dropdown values being reversed in forms Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

@RCheesley RCheesley RCheesley approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs code-review-passed PRs which have passed code review forms Anything related to forms ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged T1 Low difficulty to fix (issue) or test (PR)
Projects
Open Source Fridays
Status: 🥳 Done
Milestone
5.2.7
Development

Successfully merging this pull request may close these issues.

Mapped field to locale results in label and code swapped
3 participants
@biozshock @escopecz @RCheesley