Skip to content

[UXUI-192] Add modal template #15090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 12, 2025
Merged

[UXUI-192] Add modal template #15090

merged 4 commits into from
Jun 12, 2025

Conversation

andersonjeccel
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) ❌
New feature/enhancement? (use the a.x branch) ✔️
Deprecations? ❌
BC breaks? (use the c.x branch) ❌
Automated tests included? ❌
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

This PR adds a modal template to expand design capabilities.
It's particularly useful for creating expressive modals (for in-app help content) and productive (for functionalities) that rely on adding buttons and similar structures, providing the entire HTML structure + design ready for developers to use.

image

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Open the Help icon on the top right corner of the screen, click Tokens
  3. Check the dialog and its content

@andersonjeccel andersonjeccel self-assigned this Jun 10, 2025
@andersonjeccel andersonjeccel added T1 Low difficulty to fix (issue) or test (PR) user-interface Anything related to appearance, layout, and interactivity ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging refactoring The change does not change behavior but improves the code developer-experience Anything related to developer experience labels Jun 10, 2025
@andersonjeccel andersonjeccel added the enhancement Any improvement to an existing feature or functionality label Jun 10, 2025
kingsedem
kingsedem approved these changes Jun 10, 2025
View reviewed changes
Copy link

@kingsedem kingsedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected.

BEFORE

image

AFTER

image

@kingsedem kingsedem added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels Jun 10, 2025
@andersonjeccel andersonjeccel added user-testing-passed PRs which have been successfully tested by the required number of people. and removed pending-test-confirmation PR's that require one test before they can be merged labels Jun 10, 2025
@andersonjeccel andersonjeccel moved this to 🧑🏻‍💻 Needs a code review in Open Source Fridays Jun 10, 2025
shinde-rahul
shinde-rahul approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@shinde-rahul shinde-rahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goot to me!!!

@shinde-rahul shinde-rahul added code-review-passed PRs which have passed code review and removed code-review-needed PR's that require a code review before merging labels Jun 12, 2025
@shinde-rahul shinde-rahul moved this from 🧑🏻‍💻 Needs a code review to 🎉 Ready to commit in Open Source Fridays Jun 12, 2025
@shinde-rahul shinde-rahul added the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Jun 12, 2025
@escopecz escopecz merged commit 00de1d2 into mautic:7.x Jun 12, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from 🎉 Ready to commit to 🥳 Done in Open Source Fridays Jun 12, 2025
@andersonjeccel andersonjeccel deleted the UXUI-192-add-modal-template branch June 12, 2025 10:45
@escopecz escopecz added this to the 7.0.0-alpha milestone Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

+2 more reviewers

@shinde-rahul shinde-rahul shinde-rahul approved these changes

@kingsedem kingsedem kingsedem approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@andersonjeccel andersonjeccel

Labels
code-review-passed PRs which have passed code review developer-experience Anything related to developer experience enhancement Any improvement to an existing feature or functionality ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged refactoring The change does not change behavior but improves the code T1 Low difficulty to fix (issue) or test (PR) user-interface Anything related to appearance, layout, and interactivity user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
Open Source Fridays
Status: 🥳 Done
Milestone
7.0.0-alpha
Development

Successfully merging this pull request may close these issues.
4 participants
@andersonjeccel @shinde-rahul @escopecz @kingsedem