Skip to content

Updated icons for Segment Filter List #15064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jun 16, 2025
Merged

Updated icons for Segment Filter List #15064

merged 24 commits into from
Jun 16, 2025

Conversation

shinde-rahul
Copy link
Contributor

@shinde-rahul shinde-rahul commented Jun 2, 2025 •
edited
Loading

Q A
Bug fix? (use the a.b branch) ❌
New feature/enhancement? (use the a.x branch) ✔️
Deprecations? ❌
BC breaks? (use the c.x branch) ❌
Automated tests included? ✔️
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

This pull request addresses the user interface of the segment filter list by removing irrelevant icons.

Before After
Contact Contact Contact Contact
Primary Company Primary Company Primary Company Screenshot 2025-06-02 at 10 38 24 AM
behavior and action behavior and action behavior and action behavior and action
Example (custom filters) Example (custom filters) Example (custom filters) Example (custom filters)
Added filters Added filters Added filters Added filters

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Navigate to the segment, and click on New
  3. Go to the filters tab
  4. Search for filters and add.

shinde-rahul added 16 commits June 2, 2025 08:23
@codecov Codecov
Copy link

codecov bot commented Jun 2, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.40%. Comparing base (3efb6d3) to head (5cf0669).
⚠️ Report is 1114 commits behind head on 7.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                7.x   #15064      +/-   ##
============================================
+ Coverage     66.38%   66.40%   +0.02%     
- Complexity    35180    35181       +1     
============================================
  Files          2316     2317       +1     
  Lines        141762   141860      +98     
============================================
+ Hits          94108    94206      +98     
  Misses        47654    47654
Files with missing lines Coverage Δ
...p/bundles/LeadBundle/Controller/AjaxController.php 20.18% <ø> (ø)
...dBundle/EventListener/FilterOperatorSubscriber.php 100.00% <100.00%> (ø)
...Bundle/EventListener/GeneratedColumnSubscriber.php 100.00% <100.00%> (ø)
...dles/LeadBundle/Segment/SegmentFilterIconTrait.php 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shinde-rahul shinde-rahul changed the title Segment filter icon Updated icons for Segment Filter List Jun 2, 2025
@shinde-rahul shinde-rahul mentioned this pull request Jun 2, 2025
Closed
@shinde-rahul shinde-rahul marked this pull request as ready for review June 2, 2025 05:18
@shinde-rahul shinde-rahul added user-interface Anything related to appearance, layout, and interactivity ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging user-experience Anything related to related to workflows, feedback, and navigation segments Anything related to segments labels Jun 4, 2025
@shinde-rahul shinde-rahul moved this to 🧑🏻‍💻 Needs a code review in Open Source Fridays Jun 4, 2025
andersonjeccel
andersonjeccel approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@andersonjeccel andersonjeccel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's there!

image

@andersonjeccel andersonjeccel added T1 Low difficulty to fix (issue) or test (PR) user-testing-passed PRs which have been successfully tested by the required number of people. ux-review-passed and removed ready-to-test PR's that are ready to test labels Jun 10, 2025
patrykgruszka
patrykgruszka approved these changes Jun 12, 2025
View reviewed changes
Copy link
Member

@patrykgruszka patrykgruszka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine 👍

@shinde-rahul shinde-rahul added code-review-passed PRs which have passed code review ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed code-review-needed PR's that require a code review before merging labels Jun 13, 2025
@shinde-rahul shinde-rahul moved this from 🧑🏻‍💻 Needs a code review to 🎉 Ready to commit in Open Source Fridays Jun 13, 2025
@escopecz escopecz added this to the 7.0.0-alpha milestone Jun 16, 2025
@escopecz escopecz merged commit 5c26aa9 into mautic:7.x Jun 16, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from 🎉 Ready to commit to 🥳 Done in Open Source Fridays Jun 16, 2025
@escopecz escopecz added the enhancement Any improvement to an existing feature or functionality label Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrykgruszka patrykgruszka patrykgruszka approved these changes

+1 more reviewer

@andersonjeccel andersonjeccel andersonjeccel approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
code-review-passed PRs which have passed code review enhancement Any improvement to an existing feature or functionality ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged segments Anything related to segments T1 Low difficulty to fix (issue) or test (PR) user-experience Anything related to related to workflows, feedback, and navigation user-interface Anything related to appearance, layout, and interactivity user-testing-passed PRs which have been successfully tested by the required number of people. ux-review-passed
Projects
Open Source Fridays
Status: 🥳 Done
Milestone
7.0.0-alpha
Development

Successfully merging this pull request may close these issues.
4 participants
@shinde-rahul @patrykgruszka @andersonjeccel @escopecz