Fix report scheduled emails not being sent with proper options #15052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 5.2 #15052 +/- ##
============================================
+ Coverage 63.72% 63.75% +0.02%
- Complexity 34687 34698 +11
============================================
Files 2274 2275 +1
Lines 103776 103804 +28
============================================
+ Hits 66131 66176 +45
+ Misses 37645 37628 -17
🚀 New features to boost your workflow:
|
63cab7b to
de05275
Compare
1 task
|
@biozshock could you please review CI ? Tests are failing. We'll close the next version in a few days. Thanks. |
e9d4a83 to
f86e4e0
Compare
|
@npracht That's a known issue with M5 tests ran between 21:00 and 2:00 UTC. Just need to restart the build. |
oltmanns-leuchtfeuer
approved these changes
Jun 13, 2025
|
JonasLudwig1998
approved these changes
Jun 27, 2025
kuzmany
requested changes
Jun 30, 2025
There was a problem hiding this comment.
Seems good to me
I am just bit aware of do that operation also for each email with attachment. With mass volume sending of email it's not necessary. Would consider add check if it's report attachment.
@biozshock WDYT?
kuzmany
approved these changes
Jun 30, 2025
kuzmany
added a commit
to kuzmany/mautic
that referenced
this pull request
Jun 30, 2025
The test was failing because it was checking for messages after they were consumed and removed by messenger:consume. The fix checks for the queued message before consumption, which properly validates that the delayed transport functionality is working. - Remove flawed logic that checked for messages after messenger:consume - Add proper validation by checking for queued messages before consumption - This correctly tests the delayed transport feature from PR mautic#15052 - Files existence is validated at the appropriate time in the test flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR fixes #14976
The PR also fixes a couple of issues (covered by test):
Failed to start the session because headers have already been sent by "/var/www/html/vendor/phpunit/phpunit/src/Util/Printer.php" at line 104.📋 Steps to test this PR: