Skip to content

Fix dynamic content blocks showing multiple editors [mautic 5] #14925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

Fix dynamic content blocks showing multiple editors [mautic 5] #14925

merged 1 commit into from
Jun 20, 2025

Conversation

LordRembo
Copy link
Contributor

@LordRembo LordRembo commented Apr 25, 2025 •
edited
Loading

Q A
Bug fix? (use the a.b branch) ✔️
New feature/enhancement? (use the a.x branch) ❌
Deprecations? ❌
BC breaks? (use the c.x branch) ❌
Automated tests included? ✔️
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #14288..

Description

This fixes the issue described in #14288, by rebuilding the GrapesJS code inside the GrapesJSBuilder plugin using version 5.2 of the GrapesJS mautic preset.

📋 Steps to test this PR:

  • Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  • create an email with blank template and edit it with the grapesjs builder
  • add a dynamic content block
  • put some dummy text in it
  • click '+New' to add another variant in that dialog, add some random text
  • close the modal
  • double-click the content block to open it again
  • click '+New' to add a new variat
  • There should only be 1 CKEditor field

@LordRembo LordRembo changed the title Rebuild grapesjs using 5.2 branch of mautic preset [mautic 5] Fix dynamic content blocks showing multiple editors [mautic 5] Apr 25, 2025
@LordRembo LordRembo mentioned this pull request Apr 25, 2025
Closed
1 task
@LordRembo LordRembo added ready-to-test PR's that are ready to test builder-grapesjs Anything related to the GrapesJS email or landing page builders labels Apr 25, 2025
@LordRembo LordRembo moved this to 🦸🏻 Needs 2 tests in Open Source Fridays Apr 25, 2025
@LordRembo LordRembo modified the milestone: 5.2.9 Apr 25, 2025
@LordRembo LordRembo mentioned this pull request Apr 25, 2025
Merged
@matbcvo matbcvo added the bug Issues or PR's relating to bugs label Apr 25, 2025
@LordRembo LordRembo force-pushed the fix/14288-multiple-editors-5 branch from 6992c04 to 9371480 Compare April 28, 2025 08:37
@matbcvo matbcvo added this to the 5.2.6 milestone Apr 29, 2025
@matbcvo matbcvo linked an issue Apr 29, 2025 that may be closed by this pull request
Multiple dynamic content blocks show multiple editors #14288
Closed
1 task
@LordRembo LordRembo force-pushed the fix/14288-multiple-editors-5 branch from 9371480 to 099e197 Compare May 19, 2025 12:30
@LordRembo LordRembo moved this from 🦸🏻 Needs 2 tests to 🎉 Ready to commit in Open Source Fridays May 19, 2025
@LordRembo
Copy link
Contributor Author

Since the preset repo MR was tested, validated & merged, it should be OK to merge this MR

@nick-vanpraet nick-vanpraet modified the milestones: 5.2.6, 5.2.7 May 26, 2025
kuzmany
kuzmany approved these changes Jun 19, 2025
View reviewed changes
Copy link
Member

@kuzmany kuzmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me 👍

@kuzmany kuzmany added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels Jun 19, 2025
@kuzmany kuzmany moved this from 🎉 Ready to commit to ⏳︎ Needs 1 more test in Open Source Fridays Jun 19, 2025
MadlenF
MadlenF approved these changes Jun 20, 2025
View reviewed changes
Copy link

@MadlenF MadlenF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Gitpod, works as described 👍

@kuzmany kuzmany removed the pending-test-confirmation PR's that require one test before they can be merged label Jun 20, 2025
@kuzmany kuzmany merged commit 9b82e89 into mautic:5.2 Jun 20, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from ⏳︎ Needs 1 more test to 🥳 Done in Open Source Fridays Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuzmany kuzmany kuzmany approved these changes

+1 more reviewer

@MadlenF MadlenF MadlenF approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs builder-grapesjs Anything related to the GrapesJS email or landing page builders
Projects
Open Source Fridays
Status: 🥳 Done
Milestone
5.2.7
Development

Successfully merging this pull request may close these issues.

Multiple dynamic content blocks show multiple editors
5 participants
@LordRembo @kuzmany @MadlenF @matbcvo @nick-vanpraet