Skip to content

Dpmma 3016 extend focusitem reports 7x #14923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 14, 2025
Merged

Dpmma 3016 extend focusitem reports 7x #14923

merged 13 commits into from
May 14, 2025

Conversation

AlanWierzchonCA
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) ❌
New feature/enhancement? (use the a.x branch) ✔️
Deprecations? ❌
BC breaks? (use the c.x branch) ❌
Automated tests included? ✔️
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

This PR extends the report data source called 'Focus Stats' with columns:

  • Focus ID
  • Focus Category
  • Submission ratio
  • Click ratio

change the report data source called 'Focus Stats' with columns

  • "Page Hit" to "Hit" and "Unique Hit": now mining hit for submission, click, view records

image

Adds an extra report data source called 'Focus Leads' for reports Focus Items per Leads records.

image

image

Report Focus Stats:

image

Report Focus Leads:

image

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)

  2. Create some focus stats data by:

    1. Creating multiple focus items
    2. Adding focus items to a landing page
    3. Open the landing pages in different incognito browser windows multiple times to add some views / views+clicks

  3. Create 2 reports with data source

    1. focus stats and select all columns
    2. focus leads and select all columns

  4. Check if all the data in the reports corresponds to your behavior from 2.3 (you can also check in your database via the tables focus, focus_stats, channel_url_trackables, page_redirects)

@AlanWierzchonCA AlanWierzchonCA changed the title Dpmma 3016 focusitem reports 7x Dpmma 3016 extend focusitem reports 7x Apr 25, 2025
@AlanWierzchonCA AlanWierzchonCA mentioned this pull request Apr 25, 2025
Open
@codecov Codecov
Copy link

codecov bot commented Apr 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.63014% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.77%. Comparing base (8508000) to head (3afc7cc).
Report is 77 commits behind head on 7.x.

Files with missing lines Patch % Lines
...uticFocusBundle/EventListener/ReportSubscriber.php 98.63% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                7.x   #14923      +/-   ##
============================================
+ Coverage     65.71%   65.77%   +0.05%     
- Complexity    34988    35002      +14     
============================================
  Files          2301     2301              
  Lines        140726   140856     +130     
============================================
+ Hits          92484    92651     +167     
+ Misses        48242    48205      -37
Files with missing lines Coverage Δ
...uticFocusBundle/EventListener/ReportSubscriber.php 99.02% <98.63%> (-0.98%) ⬇️

... and 69 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlanWierzchonCA AlanWierzchonCA marked this pull request as ready for review April 25, 2025 15:38
@escopecz
Copy link
Member

@AlanWierzchonCA there is no need to push separate PRs for M6 and and M7. Both versions aren't that far from each other and will be back-merge after M6 release. Do you think we could close this one?

@patrykgruszka
Copy link
Member

@escopecz should we proceed with this PR if M6 is only accepting fixes?

@AlanWierzchonCA
Copy link
Contributor Author

@patrykgruszka @escopecz I prepared #14922 for M6

patrykgruszka
patrykgruszka requested changes May 9, 2025
View reviewed changes
Copy link
Member

@patrykgruszka patrykgruszka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, I've added few suggestions to the code.

Contacts report data is fine, but there is a missing translation for datasource:
image

Focus stats:
image

@AlanWierzchonCA AlanWierzchonCA force-pushed the DPMMA-3016_focusitem_reports_7x branch from 7d2f59a to 33512c9 Compare May 9, 2025 14:59
@AlanWierzchonCA AlanWierzchonCA force-pushed the DPMMA-3016_focusitem_reports_7x branch from 33512c9 to 3afc7cc Compare May 9, 2025 15:09
patrykgruszka
patrykgruszka approved these changes May 12, 2025
View reviewed changes
Copy link
Member

@patrykgruszka patrykgruszka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks fine 👍

@patrykgruszka patrykgruszka added pending-test-confirmation PR's that require one test before they can be merged enhancement Any improvement to an existing feature or functionality reports Anything related to reports code-review-passed PRs which have passed code review labels May 12, 2025
@patrykgruszka patrykgruszka moved this to ⏳︎ Needs 1 more test in Open Source Fridays May 12, 2025
@escopecz escopecz added this to the 7.0.0-alpha milestone May 14, 2025
escopecz
escopecz approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issues in the code 👍

@escopecz escopecz added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged user-testing-passed PRs which have been successfully tested by the required number of people. and removed pending-test-confirmation PR's that require one test before they can be merged labels May 14, 2025
@escopecz escopecz merged commit 4bcfd45 into mautic:7.x May 14, 2025
18 checks passed
@github-project-automation github-project-automation bot moved this from ⏳︎ Needs 1 more test to 🥳 Done in Open Source Fridays May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

@patrykgruszka patrykgruszka patrykgruszka approved these changes

Assignees
No one assigned
Labels
code-review-passed PRs which have passed code review enhancement Any improvement to an existing feature or functionality ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged reports Anything related to reports user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
Open Source Fridays
Status: 🥳 Done
Milestone
7.0.0-alpha
Development

Successfully merging this pull request may close these issues.
3 participants
@AlanWierzchonCA @escopecz @patrykgruszka