Skip to content

Fix "social login" field in Form. #14919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2025
Merged

Fix "social login" field in Form. #14919

merged 1 commit into from
Apr 26, 2025

Conversation

biozshock
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) ✔️
New feature/enhancement? (use the a.x branch) ❌
Deprecations? ❌
BC breaks? (use the c.x branch) ❌
Automated tests included? ✔️
Issue(s) addressed Fixes #12926

Description

Fix "social login" form field in Form.

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Enable Twitter plugin.
  3. Create new form.
  4. Add "Socal login" field type.
  5. Try to save the form.

@matbcvo
Copy link
Contributor

matbcvo commented Apr 25, 2025

@biozshock, could you please rebase your PR onto the 5.2 branch? Based on issue #12926, this bug exists in Mautic 5. We’ll merge it into the 6.0 and 7.x branches later on.

@matbcvo matbcvo added bug Issues or PR's relating to bugs forms Anything related to forms twig labels Apr 25, 2025
@matbcvo matbcvo linked an issue Apr 25, 2025 that may be closed by this pull request
Error 500 when saving form with "Social login" field #12926
Closed
1 task
@biozshock biozshock changed the base branch from 6.0 to 5.2 April 25, 2025 19:44
@biozshock
Copy link
Contributor Author

@matbcvo Thought the 5.x branch will not receive patches anymore.

@codecov Codecov
Copy link

codecov bot commented Apr 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.75%. Comparing base (360c090) to head (131fda8).
Report is 2 commits behind head on 5.2.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                5.2   #14919      +/-   ##
============================================
+ Coverage     63.67%   64.75%   +1.08%     
- Complexity    34662    34728      +66     
============================================
  Files          2273     2275       +2     
  Lines        103706   103738      +32     
============================================
+ Hits          66032    67173    +1141     
+ Misses        37674    36565    -1109

see 658 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matbcvo matbcvo added ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging labels Apr 25, 2025
@matbcvo matbcvo added this to the 5.2.5 milestone Apr 25, 2025
matbcvo
matbcvo approved these changes Apr 26, 2025
View reviewed changes
Copy link
Contributor

@matbcvo matbcvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good to me. I've tested the PR and can confirm that it fixes the issue. Thank you! 👍

@matbcvo
Copy link
Contributor

matbcvo commented Apr 26, 2025

@matbcvo Thought the 5.x branch will not receive patches anymore.

5.2.7 (scheduled for 30th June 2025) will be the last version to receive bug fixes.

@matbcvo matbcvo added code-review-passed PRs which have passed code review user-testing-passed PRs which have been successfully tested by the required number of people. ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed code-review-needed PR's that require a code review before merging ready-to-test PR's that are ready to test labels Apr 26, 2025
@matbcvo matbcvo merged commit cc553cb into mautic:5.2 Apr 26, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matbcvo matbcvo matbcvo approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs code-review-passed PRs which have passed code review forms Anything related to forms ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged twig user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
Open Source Fridays
Status: 🥳 Done
Milestone
5.2.5
Development

Successfully merging this pull request may close these issues.

Error 500 when saving form with "Social login" field
2 participants
@biozshock @matbcvo