fix: [DPMMA-3098] fix report data bool filter #14909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.2 #14909 +/- ##
============================================
+ Coverage 63.27% 63.68% +0.40%
- Complexity 34619 34676 +57
============================================
Files 2272 2274 +2
Lines 103558 103729 +171
============================================
+ Hits 65530 66058 +528
+ Misses 38028 37671 -357 🚀 New features to boost your workflow:
|
|
Can you rebase this onto the 5.2 branch? We should have this fix in that version. |
|
@AlanWierzchonCA, just a heads-up, it needs to be rebased onto the 5.2 branch, not 5.x. The 5.x branch is locked and doesn’t accept any PRs. We'll merge it into the 6.0 and 7.x branches later. |
364aefa to
57f7984
Compare
|
@patrykgruszka @matbcvo rebased this onto the 5.2 branch |
|
This fix makes the boolean appear, but there’s another issue - the boolean value is not being saved. I checked the database and confirmed that the boolean value is not being saved or updated. For example, the "Dynamic?" boolean works correctly. Screen.Recording.2025-04-26.180515.mp4 |
|
I have tested this PR locally, and everything works correctly with the latest commit ✅ |
kuzmany
approved these changes
Apr 29, 2025
patrykgruszka
requested changes
Apr 29, 2025
There was a problem hiding this comment.
This approach will cause ID conflicts, I would suggest to try with something like this:
if (filterType == 'bool' || filterType == 'boolean') {
const yesId = valueId + '_1';
const noId = valueId + '_0';
const isYes = valueVal == '1';
const $template = mQuery(mQuery('#filterValueYesNoTemplate').html());
const $label = $template.find('#report_value_template_yesno_label');
const $yesOption = $template.find('#report_value_template_yesno_1');
const $noOption = $template.find('#report_value_template_yesno_0');
$yesOption.attr('name', valueName)
.attr('id', yesId);
$noOption.attr('name', valueName)
.attr('id', noId);
$label.attr('id', valueId + '_bool-label')
.attr('data-yes-id', yesId)
.attr('data-no-id', noId);
mQuery(valueEl).replaceWith($template);
if (!isYes) {
Mautic.toggleYesNo($label);
}
} else if // ....
26a6401 to
c2f0b78
Compare
|
@kuzmany , @matbcvo I made changes as suggested by @patrykgruszka |
69ad29b to
b5124b7
Compare
patrykgruszka
approved these changes
Apr 29, 2025
shinde-rahul
approved these changes
May 5, 2025
|
Once this change is applied, I can toggle the boolean for the isPublished column under filters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for Issue: #14857
Bug: "Is Published" filter in Reports doesn't allow selecting "True" or "False"
📋 Steps to test this PR: