Skip to content

Conversation

npracht
Copy link
Member

@npracht npracht commented Apr 23, 2025

Q A
Bug fix? (use the a.b branch) ✔️
New feature/enhancement? (use the a.x branch)
Deprecations?
BC breaks? (use the c.x branch)
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issue(s) addressed

Description

In the setting of a report, you have this toggle with Tooltip. The tooltip contains double quotes (obvisouly people tried to escape it but not working). It makes the translation borken.
Capture d’écran 2025-04-23 à 10 12 14

I removed the quotes.

📋 Steps to test this PR:

  1. Browse Reports > New > right setting panel and see the broken tooltip
  2. Apply fix and check it again.

@npracht npracht added T1 Low difficulty to fix (issue) or test (PR) bug Issues or PR's relating to bugs translations Anything related to translations user-interface Anything related to appearance, layout, and interactivity labels Apr 23, 2025
@npracht npracht moved this to 🦸🏻 Needs 2 tests in Open Source Fridays Apr 23, 2025
@matbcvo matbcvo added this to the 5.2.5 milestone Apr 23, 2025
@matbcvo matbcvo changed the title Remove double quote in translations because it breaks it Fix broken translation caused by double quotes in tooltip Apr 23, 2025
Co-authored-by: Martin Vooremäe <martin.vooremae@gmail.com>
@npracht npracht requested a review from matbcvo April 23, 2025 11:52
Copy link
Contributor

@matbcvo matbcvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good to me. I've tested the PR and it works as expected. Thank you!

image

@matbcvo matbcvo merged commit 25cdf9b into mautic:5.2 Apr 23, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from 🦸🏻 Needs 2 tests to 🥳 Done in Open Source Fridays Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs T1 Low difficulty to fix (issue) or test (PR) translations Anything related to translations user-interface Anything related to appearance, layout, and interactivity
Projects
Status: 🥳 Done
Development

Successfully merging this pull request may close these issues.

2 participants