Fix #14240: Blank link shown in theme actions dropdown #14833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for this fix! It's amazing!
|
When clicking to open the list dropdown for a theme on the Themes page, blank links are shown at the top and it happens only for themes that are not set as system theme. To fix this, Resources/views/Theme/list.html.twig was updated to prevent empty button definitions from being added to the `customButtons` array. Now, only buttons with proper attributes are merged into the list of actions shown in the dropdown menu. An E2E test is included to verify that no links with `data-toggle="ajax"` are rendered without a `href` attribute.
42456c2 to
61db15b
Compare
|
Hi @escopecz, just following up — the changes were pushed over the weekend:
Let me know if this aligns with what you had in mind, and I’m happy to adjust if needed. Appreciate your time! |
escopecz
previously approved these changes
Apr 7, 2025
|
One last thing is that the CS Fixer is failing. Please run To fix these issues. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 6.0 #14833 +/- ##
============================================
- Coverage 64.75% 64.74% -0.01%
Complexity 34728 34728
============================================
Files 2275 2275
Lines 103739 103739
============================================
- Hits 67171 67170 -1
- Misses 36568 36569 +1 🚀 New features to boost your workflow:
|
Fixes PHP CS violations flagged during review. No logic or structure changes were made — only style adjustments in accordance with the `.php-cs-fixer.php` config.
escopecz
approved these changes
Apr 7, 2025
|
@all-contributors please add @pedroasgomes for code |
|
I've put up a pull request to add @pedroasgomes! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the dropdown menu for individual non-system themes showed a blank link in the list of available actions. The issue was caused by empty button definitions being passed to the
customButtonsarray in the Twig template.To fix this, the
list.html.twigfile was updated to ensure that only properly defined buttons are merged into thecustomButtonsarray. Buttons such as the preview or visibility toggles are now conditionally added only when they are not empty, preventing malformed entries from being rendered.An E2E test is included to ensure that no action link with
data-toggle="ajax"is rendered without a correspondinghrefattribute.📋 Steps to test this PR: