Skip to content

Revert "[UX] Improving saving options for Categories: Save only" #14819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2025
Merged

Revert "[UX] Improving saving options for Categories: Save only" #14819

merged 1 commit into from
Mar 31, 2025

Conversation

escopecz
Copy link
Member

Reverts #14680 because it causes errors like this one:

#14813 (review)

@Copilot Copilot AI review requested due to automatic review settings March 31, 2025 11:18
Copilot
Copilot AI reviewed Mar 31, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • app/bundles/CategoryBundle/Form/Type/CategoryType.php: Language not supported

@escopecz escopecz requested a review from andersonjeccel March 31, 2025 11:18
@escopecz escopecz mentioned this pull request Mar 31, 2025
Merged
@codecov Codecov
Copy link

codecov bot commented Mar 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.74%. Comparing base (12f062e) to head (ad1d001).
Report is 2 commits behind head on 6.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                6.x   #14819      +/-   ##
============================================
- Coverage     64.75%   64.74%   -0.01%     
  Complexity    34728    34728              
============================================
  Files          2275     2275              
  Lines        103739   103738       -1     
============================================
- Hits          67171    67169       -2     
- Misses        36568    36569       +1
Files with missing lines Coverage Δ
.../bundles/CategoryBundle/Form/Type/CategoryType.php 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

andersonjeccel
andersonjeccel approved these changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@andersonjeccel andersonjeccel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Effectively reverts

@andersonjeccel andersonjeccel added T1 Low difficulty to fix (issue) or test (PR) bug Issues or PR's relating to bugs categories Anything related to categories code-review-passed PRs which have passed code review user-testing-passed PRs which have been successfully tested by the required number of people. ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged labels Mar 31, 2025
@escopecz escopecz added this to the 6.0.1 milestone Mar 31, 2025
@escopecz escopecz merged commit f4bec48 into 6.x Mar 31, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@matbcvo matbcvo matbcvo approved these changes

+1 more reviewer

@andersonjeccel andersonjeccel andersonjeccel approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs categories Anything related to categories code-review-passed PRs which have passed code review ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged T1 Low difficulty to fix (issue) or test (PR) user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
None yet
Milestone
6.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@escopecz @matbcvo @andersonjeccel