Skip to content

Allow plugins to close modal window when error happens #14813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2025
Merged

Allow plugins to close modal window when error happens #14813

merged 1 commit into from
Mar 31, 2025

Conversation

nileshlohar
Copy link
Contributor

@nileshlohar nileshlohar commented Mar 28, 2025 •
edited
Loading

Q A
Bug fix? (use the a.b branch) ✔️
New feature/enhancement? (use the a.x branch) ❌
Deprecations? ❌
BC breaks? (use the c.x branch) ❌
Automated tests included? ❌
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Edit Categories modal should open as expected.

@dongilbert @nileshlohar
Merge pull request mautic#1282 from acquia/CF-297
64ab29f 
CF-297 Golden template_Category_Edit popup is displayed in child instance for inherited resource
@nileshlohar nileshlohar requested review from a team, escopecz and aarohiprasad and removed request for a team March 28, 2025 13:36
@nileshlohar nileshlohar added the unforking Used for PRs in the Acquia's unforking initiative label Mar 28, 2025
escopecz
escopecz approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issue with adding this code as it allows plugins to be able to close the modal when specific error happens.

@escopecz escopecz added the enhancement Any improvement to an existing feature or functionality label Mar 28, 2025
@escopecz escopecz changed the title Category edit modal doesn't open in loading state. Allow plugins to close modal window when error happens Mar 28, 2025
@escopecz escopecz added pending-test-confirmation PR's that require one test before they can be merged plugin Anything related to plugins code-review-passed PRs which have passed code review labels Mar 28, 2025
aarohiprasad
aarohiprasad suggested changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@aarohiprasad aarohiprasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit modal is working fine. The changes are also being save correctly when clicking 'Save & Close'. But it is yielding this error:
image

@escopecz
Copy link
Member

@aarohiprasad this will be unrelated to this PR, I'm afraid.

@andersonjeccel this may be related to the PR that was hiding the Apply button.

@andersonjeccel
Copy link
Contributor

@escopecz yeah, faced an error some hours ago, I'm sure it's because of that PR

@andersonjeccel
Copy link
Contributor

@escopecz could you revert?

@escopecz
Copy link
Member

@andersonjeccel is it this one? #14680

kuzmany
kuzmany approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@kuzmany kuzmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 👍

@andersonjeccel
Copy link
Contributor

@escopecz yes

@escopecz escopecz mentioned this pull request Mar 31, 2025
Merged
@escopecz escopecz removed the pending-test-confirmation PR's that require one test before they can be merged label Mar 31, 2025
@escopecz escopecz added this to the 7.0.0-alpha milestone Mar 31, 2025
@escopecz
Copy link
Member

@andersonjeccel revert PR created: #14819

@escopecz escopecz merged commit 176262b into mautic:7.x Mar 31, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuzmany kuzmany kuzmany approved these changes

@escopecz escopecz escopecz approved these changes

+1 more reviewer

@aarohiprasad aarohiprasad aarohiprasad requested changes

Reviewers whose approvals may not affect merge requirements
Assignees

@aarohiprasad aarohiprasad

Labels
code-review-passed PRs which have passed code review enhancement Any improvement to an existing feature or functionality plugin Anything related to plugins unforking Used for PRs in the Acquia's unforking initiative
Projects
None yet
Milestone
7.0.0-alpha
Development

Successfully merging this pull request may close these issues.
6 participants
@nileshlohar @escopecz @andersonjeccel @kuzmany @aarohiprasad @dongilbert