Upgrading several libraries to support Symfony 7 #14810

escopecz · 2025-03-27T17:45:11Z

Q	A
Bug fix? (use the a.b branch)	❌
New feature/enhancement? (use the a.x branch)	✔️
Deprecations?	❌
BC breaks? (use the c.x branch)	❌
Automated tests included?	✔️ yea, if the e2e tests pass then we are good
Related user documentation PR URL	mautic/user-documentation#...
Related developer documentation PR URL	mautic/developer-documentation-new#...
Issue(s) addressed	Fixes #...

Description

Codeception is one of the libraries we'll have to update to get to Symfony 7. See

composer why-not symfony/console 7.2
doctrine/migrations      3.5.5     requires  symfony/console (^4.4.16 || ^5.4 || ^6.0)      
mautic/core-lib          7.0.0-dev requires  symfony/console (^6.4)                         
psy/psysh                v0.11.22  requires  symfony/console (^6.0 || ^5.0 || ^4.0 || ^3.4) 
symfony/framework-bundle v6.4.13   conflicts symfony/console (<5.4|>=7.0)

I run this: composer update codeception/* --dev -W

And then:

composer why-not symfony/console 7.2
doctrine/migrations      3.5.5     requires  symfony/console (^4.4.16 || ^5.4 || ^6.0) 
mautic/core-lib          7.0.0-dev requires  symfony/console (^6.4)                    
symfony/framework-bundle v6.4.13   conflicts symfony/console (<5.4|>=7.0)

Full list of dependency upgrades:

Lock file operations: 0 installs, 26 updates, 5 removals
  - Removing phpdocumentor/reflection-common (2.2.0)
  - Removing phpdocumentor/reflection-docblock (5.6.1)
  - Removing phpdocumentor/type-resolver (1.10.0)
  - Removing phpspec/prophecy (v1.18.0)
  - Removing webmozart/assert (1.11.0)
  - Upgrading behat/gherkin (v4.9.0 => v4.12.0)
  - Upgrading codeception/codeception (5.1.2 => 5.2.1)
  - Upgrading codeception/lib-asserts (2.1.0 => 2.2.0)
  - Upgrading codeception/lib-web (1.0.6 => 1.0.7)
  - Upgrading codeception/module-db (3.1.4 => 3.2.2)
  - Upgrading codeception/stub (4.1.3 => 4.1.4)
  - Upgrading doctrine/instantiator (1.5.0 => 2.0.0)
  - Upgrading guzzlehttp/psr7 (2.6.2 => 2.7.1)
  - Upgrading myclabs/deep-copy (1.11.1 => 1.13.0)
  - Upgrading nikic/php-parser (v4.19.4 => v5.4.0)
  - Upgrading phar-io/manifest (2.0.3 => 2.0.4)
  - Upgrading php-webdriver/webdriver (1.15.1 => 1.15.2)
  - Upgrading phpunit/php-code-coverage (9.2.15 => 9.2.32)
  - Upgrading phpunit/phpunit (9.5.20 => 9.6.22)
  - Upgrading psr/http-factory (1.0.2 => 1.1.0)
  - Upgrading psy/psysh (v0.11.22 => v0.12.8)
  - Upgrading sebastian/cli-parser (1.0.1 => 1.0.2)
  - Upgrading sebastian/exporter (4.0.5 => 4.0.6)
  - Upgrading sebastian/global-state (5.0.6 => 5.0.7)
  - Upgrading sebastian/resource-operations (3.0.3 => 3.0.4)
  - Upgrading symfony/console (v6.4.15 => v6.4.17)
  - Upgrading symfony/finder (v6.4.13 => v6.4.17)
  - Upgrading symfony/string (v6.4.15 => v7.2.0)
  - Upgrading symfony/var-dumper (v6.4.15 => v6.4.18)
  - Upgrading symfony/yaml (v6.4.13 => v6.4.18)
  - Upgrading theseer/tokenizer (1.2.2 => 1.2.3)

As this have updated also PHPUNIT then PHPSTAN started complaining about deprecated method. I found a Rector rule to refactor that. I created this Rector config just for tests because the tests are excluded from normal Rector config.

<?php

declare(strict_types=1);

use Rector\Config\RectorConfig;
use Rector\PHPUnit\PHPUnit100\Rector\StmtsAwareInterface\WithConsecutiveRector;

return RectorConfig::configure()
    ->withPaths([
        __DIR__ . '/app/bundles',
        __DIR__ . '/plugins',
    ])
    ->withRules([
        WithConsecutiveRector::class,
    ]);

This helped with replacing the deprecated method. However, it also broke a lot of unit tests, so I had to manually fix them. That's the majority of changes in this PR>

📋 Steps to test this PR:

Most of the changes are in the unit tests, so no production code was changed.

If the GH Actions are green then we are good.

…ame() when expecting " By using AssertSameBoolNullToSpecificMethodRector

Copilot

Copilot reviewed 79 out of 99 changed files in this pull request and generated no comments.

Files not reviewed (20)

app/bundles/ApiBundle/Tests/EventListener/ApiSubscriberTest.php: Language not supported
app/bundles/ApiBundle/Tests/Form/Type/ClientTypeTest.php: Language not supported
app/bundles/AssetBundle/Tests/Model/AssetModelTest.php: Language not supported
app/bundles/CampaignBundle/Tests/Executioner/Dispatcher/ActionDispatcherTest.php: Language not supported
app/bundles/CampaignBundle/Tests/Executioner/Dispatcher/ConditionDispatcherTest.php: Language not supported
app/bundles/CampaignBundle/Tests/Executioner/Dispatcher/LegacyEventDispatcherTest.php: Language not supported
app/bundles/CampaignBundle/Tests/Executioner/EventExecutionerTest.php: Language not supported
app/bundles/CampaignBundle/Tests/Executioner/KickoffExecutionerTest.php: Language not supported
app/bundles/CampaignBundle/Tests/Executioner/ScheduledExecutionerTest.php: Language not supported
app/bundles/CampaignBundle/Tests/Executioner/Scheduler/EventSchedulerTest.php: Language not supported
app/bundles/CampaignBundle/Tests/Helper/NotificationHelperTest.php: Language not supported
app/bundles/CampaignBundle/Tests/Membership/MembershipBuilderTest.php: Language not supported
app/bundles/CampaignBundle/Tests/Service/CampaignAuditServiceTest.php: Language not supported
app/bundles/CategoryBundle/Tests/Model/ContactActionModelTest.php: Language not supported
app/bundles/ChannelBundle/Tests/Model/ChannelActionModelTest.php: Language not supported
app/bundles/ChannelBundle/Tests/Model/FrequencyActionModelTest.php: Language not supported
app/bundles/CoreBundle/Tests/EventListener/DashboardSubscriberTest.php: Language not supported
app/bundles/CoreBundle/Tests/Unit/EventListener/CommonStatsSubscriberTest.php: Language not supported
app/bundles/CoreBundle/Tests/Unit/Form/Type/ContentPreviewSettingsTypeTest.php: Language not supported
app/bundles/CoreBundle/Tests/Unit/Form/Type/DynamicContentFilterEntryFiltersTypeTest.php: Language not supported

codecov · 2025-03-30T19:11:01Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.59%. Comparing base (622a33f) to head (4f07631).
⚠️ Report is 1909 commits behind head on 7.x.

Additional details and impacted files

@@             Coverage Diff              @@
##                7.x   #14810      +/-   ##
============================================
+ Coverage     65.06%   65.59%   +0.52%     
- Complexity    34873    34908      +35     
============================================
  Files          2294     2296       +2     
  Lines        103999   140433   +36434     
============================================
+ Hits          67666    92114   +24448     
- Misses        36333    48319   +11986

see 1652 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

biozshock · 2025-03-30T19:56:33Z

@escopecz damn, i'm on the upgrade to phpunit 10, using my simple library: https://github.com/biozshock/phpunit-consecutive . Only phpstan is left to fix to release a PR :)

patrykgruszka

Looks good 👍 PR removes outdated test methods, making the tests clearer and easier to debug.

matbcvo

The code changes look good to me. 👍

escopecz added 3 commits March 27, 2025 18:42

Bumping codeception/* to a newer version that supports Symfony 7

2886866

Using WithConsecutiveRector for updating the deprecated method

3176430

Manually fixing Rector's changes

0a246af

escopecz force-pushed the updating-codeception branch from 7ef35fd to 0a246af Compare March 27, 2025 18:58

escopecz added 6 commits March 29, 2025 15:53

Fixing PHPSTAN error "You should use assertFalse() instead of assertS…

587f329

…ame() when expecting " By using AssertSameBoolNullToSpecificMethodRector

Manual fixes of PHPSTAN errors after WithConsecutiveRector

95f3aaa

Batch of test fixes after PHPUNIT upgrade and Rector

61b430f

Another batch of broken test fixes after Rector rule was run

fd6a89a

More manual unit test fixes after PHPUNIT upgrade and Rector refactoring

5dff094

Running composer fixcs

c5b1163

escopecz force-pushed the updating-codeception branch from 8cc6f64 to c5b1163 Compare March 30, 2025 18:53

escopecz changed the title ~~Bumping codeception/* to a newer version that supports Symfony 7~~ Upgrading several libraries to support Symfony 7 Mar 30, 2025

Removing debugging line

4f07631

escopecz marked this pull request as ready for review March 30, 2025 19:00

escopecz added code-review-needed PR's that require a code review before merging dependencies Pull requests that update a dependency file composer Any bugs or PRs relating to composer labels Mar 30, 2025

escopecz added this to the 7.0.0-alpha milestone Mar 30, 2025

escopecz requested a review from Copilot March 30, 2025 19:07

Copilot AI reviewed Mar 30, 2025

View reviewed changes

patrykgruszka approved these changes Mar 31, 2025

View reviewed changes

matbcvo approved these changes Mar 31, 2025

View reviewed changes

matbcvo added code-review-passed PRs which have passed code review ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed code-review-needed PR's that require a code review before merging labels Mar 31, 2025

escopecz merged commit a72f4a3 into mautic:7.x Mar 31, 2025
15 checks passed

escopecz added the enhancement Any improvement to an existing feature or functionality label Aug 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Upgrading several libraries to support Symfony 7 #14810

Upgrading several libraries to support Symfony 7 #14810

Uh oh!

escopecz commented Mar 27, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

codecov bot commented Mar 30, 2025 •

edited

Loading

Uh oh!

biozshock commented Mar 30, 2025

Uh oh!

patrykgruszka left a comment

Uh oh!

matbcvo left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Upgrading several libraries to support Symfony 7 #14810

Upgrading several libraries to support Symfony 7 #14810

Uh oh!

Conversation

escopecz commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

📋 Steps to test this PR:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

biozshock commented Mar 30, 2025

Uh oh!

patrykgruszka left a comment

Choose a reason for hiding this comment

Uh oh!

matbcvo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

escopecz commented Mar 27, 2025 •

edited

Loading

codecov bot commented Mar 30, 2025 •

edited

Loading