Skip to content

Removing a link from a tooltip that was showing HTML markup #14891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

Removing a link from a tooltip that was showing HTML markup #14891

merged 1 commit into from
Apr 22, 2025

Conversation

npracht
Copy link
Member

@npracht npracht commented Apr 17, 2025 •
edited
Loading

Q A
Bug fix? (use the a.b branch) ✔️
New feature/enhancement? (use the a.x branch) ❌
Deprecations? ❌
BC breaks? (use the c.x branch) ❌
Automated tests included? ❌
Related user documentation PR URL
Related developer documentation PR URL
Issue(s) addressed

Description

In Landing page UI a translation is breaking the UI.
image

I changed the trans in French, but the issue is also in english. IMO this is because of the double quotes of HTML in translations.

I removed the entire part pushing to documentation because:

  1. tootlip is not browsable (when you move it disapear you cannot click)
  2. if some day the link changes and we don't have 3xx it is 404 for sure
  3. we never add doc link in tooltip, why starting now.

📋 Steps to test this PR:

  1. use FR trans
  2. pages > new

@npracht npracht added T1 Low difficulty to fix (issue) or test (PR) bug Issues or PR's relating to bugs user-interface Anything related to appearance, layout, and interactivity landing-pages Anything related to landing pages labels Apr 17, 2025
@npracht npracht moved this to ⏳︎ Needs 1 more test in Open Source Fridays Apr 17, 2025
@npracht npracht changed the title fix borken trans in UI because of double quotes fix broken trans in UI because of double quotes Apr 17, 2025
escopecz
escopecz approved these changes Apr 18, 2025
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. How can one even click on a tooltip?

@escopecz escopecz added pending-test-confirmation PR's that require one test before they can be merged code-review-passed PRs which have passed code review labels Apr 18, 2025
@escopecz escopecz added this to the 5.2.5 milestone Apr 18, 2025
@npracht
Copy link
Member Author

npracht commented Apr 18, 2025

It is not possible 😇

shinde-rahul
shinde-rahul approved these changes Apr 20, 2025
View reviewed changes
Copy link
Contributor

@shinde-rahul shinde-rahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@npracht npracht added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Apr 20, 2025
@npracht npracht moved this from ⏳︎ Needs 1 more test to 🎉 Ready to commit in Open Source Fridays Apr 20, 2025
andersonjeccel
andersonjeccel approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@andersonjeccel andersonjeccel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing links from tooltips seems to be a great practice from now

@escopecz escopecz merged commit 3bb21ee into mautic:5.2 Apr 22, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from 🎉 Ready to commit to 🥳 Done in Open Source Fridays Apr 22, 2025
@escopecz escopecz changed the title fix broken trans in UI because of double quotes Removing a link from a tooltip that was showing HTML markup Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

+2 more reviewers

@shinde-rahul shinde-rahul shinde-rahul approved these changes

@andersonjeccel andersonjeccel andersonjeccel approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs code-review-passed PRs which have passed code review landing-pages Anything related to landing pages ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged T1 Low difficulty to fix (issue) or test (PR) user-interface Anything related to appearance, layout, and interactivity
Projects
Open Source Fridays
Status: 🥳 Done
Milestone
5.2.5
Development

Successfully merging this pull request may close these issues.
4 participants
@npracht @shinde-rahul @escopecz @andersonjeccel