Skip to content

Conversation

escopecz
Copy link
Member

@escopecz escopecz commented Apr 15, 2025

Q A
Bug fix? (use the a.b branch)
New feature/enhancement? (use the a.x branch)
Deprecations?
BC breaks? (use the c.x branch) ✔️
Automated tests included?
Related user documentation PR URL mautic/user-documentation#355
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

Another blocker to upgrade to Symfony 7 is that the new version of https://github.com/symfony/amqp-messenger requires the ext-amqp PHP extension. That would mean the Mautic installation would became even more difficult. I posted a question about what to do about it on Slack and got one reply that it should be removed and whoever wants to use RabbitMQ can install it separately.

There are other options that can work with Symfony Messenger. The simplest way is to use the Doctrine driver which will work with MySql. Another option is to use Redis that also do not need any extra PHP extensions.

I also found that we have another library for AMQP and removed it as well: https://github.com/php-amqplib/RabbitMqBundle

This PR is a result of executing composer remove symfony/amqp-messenger php-amqplib/rabbitmq-bundle which resulted in

Lock file operations: 0 installs, 1 update, 5 removals
  - Removing paragonie/constant_time_encoding (v2.6.3)
  - Removing php-amqplib/php-amqplib (v3.6.0)
  - Removing php-amqplib/rabbitmq-bundle (2.14.0)
  - Removing phpseclib/phpseclib (3.0.37)
  - Removing symfony/amqp-messenger (v5.4.45)
  - Upgrading mautic/core-lib (7.0.0-dev 54bd9d0 => 7.0.0-dev 4b70c52)

I didn't find any usages of these libraries in the code.

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. As the libraries weren't used for anything there is nothing really to test. They would be used only with special configuration I think.

Copy link
Contributor

@matbcvo matbcvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me. 👍

@matbcvo matbcvo added bc-break A BC break PR for major release milestones only code-review-passed PRs which have passed code review dependencies Pull requests that update a dependency file labels Apr 15, 2025
@matbcvo matbcvo added this to the 7.0.0-alpha milestone Apr 15, 2025
@matbcvo matbcvo added the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Apr 15, 2025
Copy link
Contributor

@shinde-rahul shinde-rahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Thanks @escopecz!!!

@escopecz escopecz merged commit 672588e into mautic:7.x Apr 16, 2025
20 checks passed
@RCheesley
Copy link
Member

@escopecz let's make sure we make a note in the release notes / blog post about this, and ensure we update https://mautic.org/mautic-requirements/ accordingly.

@escopecz
Copy link
Member Author

@RCheesley is the information in the UPGRADE-7.0.md file and the doc change not enough? It will be also in the release notes that are generated automatically. Is there something else I have to do now?

@escopecz escopecz added the bug Issues or PR's relating to bugs label Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bc-break A BC break PR for major release milestones only bug Issues or PR's relating to bugs code-review-passed PRs which have passed code review dependencies Pull requests that update a dependency file ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
Status: 🥳 Done
Development

Successfully merging this pull request may close these issues.

5 participants