Skip to content

Removing unused PHP dependencies #14850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2025
Merged

Removing unused PHP dependencies #14850

merged 2 commits into from
Apr 7, 2025

Conversation

escopecz
Copy link
Member

@escopecz escopecz commented Apr 5, 2025

Q A
Bug fix? (use the a.b branch) ✔️
New feature/enhancement? (use the a.x branch) ❌
Deprecations? ✔️
BC breaks? (use the c.x branch) ✔️
Automated tests included? ❌
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

I've tested the new agent mode and asked it to go through the composer dependencies and find unused. It identified 4 libraries and those are being removed in this PR.

After removing it from app/composer.json I also ran composer remove symfony/yaml symfony/templating symfony/security-acl symfony/css-selector which mostly resulted in updates as the libraries are used in the dependencies of dependencies. But that's OK too. The only library that was really removed is the symfony/templating which was used when we were using the PHP templates, but those were refactored to use Twig as Symfony 6 didn't support PHP templates anymore and there is no version of symfony/templating for Symfony 7.

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Let the automated tests run. That should be good enough.

@escopecz escopecz added code-review-needed PR's that require a code review before merging dependencies Pull requests that update a dependency file composer Any bugs or PRs relating to composer labels Apr 5, 2025
@escopecz escopecz added this to the 7.0.0-alpha milestone Apr 5, 2025
@escopecz escopecz added the ready-to-test PR's that are ready to test label Apr 5, 2025
matbcvo
matbcvo approved these changes Apr 5, 2025
View reviewed changes
Copy link
Contributor

@matbcvo matbcvo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a useful tool, I wasn't aware it could analyze a large codebase like that. I verified that these Symfony components aren't used. The code changes look good to me. I have tested the PR and found no issues.

@matbcvo matbcvo added pending-test-confirmation PR's that require one test before they can be merged code-review-passed PRs which have passed code review and removed code-review-needed PR's that require a code review before merging ready-to-test PR's that are ready to test labels Apr 5, 2025
shinde-rahul
shinde-rahul approved these changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@shinde-rahul shinde-rahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@escopecz escopecz added user-testing-passed PRs which have been successfully tested by the required number of people. and removed pending-test-confirmation PR's that require one test before they can be merged labels Apr 7, 2025
@escopecz escopecz merged commit dc2ff3c into mautic:7.x Apr 7, 2025
16 checks passed
@escopecz escopecz added the bug Issues or PR's relating to bugs label Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matbcvo matbcvo matbcvo approved these changes

+1 more reviewer

@shinde-rahul shinde-rahul shinde-rahul approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs code-review-passed PRs which have passed code review composer Any bugs or PRs relating to composer dependencies Pull requests that update a dependency file user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
Open Source Fridays
Status: 🥳 Done
Milestone
7.0.0-alpha
Development

Successfully merging this pull request may close these issues.
3 participants
@escopecz @matbcvo @shinde-rahul