Skip to content

Updating knplabs/knp-menu-bundle and liip/functional-test-bundle to support Symfony 7 #14849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2025
Merged

Updating knplabs/knp-menu-bundle and liip/functional-test-bundle to support Symfony 7 #14849

merged 1 commit into from
Apr 5, 2025

Conversation

escopecz
Copy link
Member

@escopecz escopecz commented Apr 4, 2025

Q A
Bug fix? (use the a.b branch) ✔️
New feature/enhancement? (use the a.x branch) ✔️
Deprecations? ❌
BC breaks? (use the c.x branch) ❌
Automated tests included? ❌
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

Another PR from the series "what needs to update so that Mautic can support Symfony 7".

Here is the list of todays blockers where you can see what this PR is targeting:

$ composer why-not symfony/framework-bundle ^7.2
Xdebug: [Step Debug] Could not connect to debugging client. Tried: host.docker.internal:9003 (fallback through xdebug.client_host/xdebug.client_port).
klapaudius/oauth-server-bundle 4.0.5     requires         symfony/framework-bundle (~6.0)                         
- knplabs/knp-menu-bundle        v3.2.0    requires         symfony/framework-bundle (^3.4 | ^4.4 | ^5.0 | ^6.0)    
- liip/functional-test-bundle    4.9.0     requires         symfony/framework-bundle (^4.4 || ^5.1 || ^6.0)         
mautic/core-lib                7.0.0-dev requires         symfony/framework-bundle (^6.4)                         
noxlogic/ratelimit-bundle      2.0.0     requires         symfony/framework-bundle (^5.4.2|^6.1)                  
symfony/framework-bundle       v7.2.5    conflicts        symfony/security-csrf (<7.2)                            
symfony/framework-bundle       v7.2.5    conflicts        symfony/serializer (<7.2.5)                             
symfony/framework-bundle       v7.2.5    requires         symfony/dependency-injection (^7.2)                     
mautic/mautic                  7.x-dev   does not require symfony/dependency-injection (but v6.4.19 is installed) 
symfony/framework-bundle       v7.2.5    requires         symfony/http-kernel (^7.2)                              
mautic/mautic                  7.x-dev   does not require symfony/http-kernel (but v6.4.16 is installed)          
symfony/framework-bundle       v7.2.5    requires         symfony/filesystem (^7.1)                               
mautic/mautic                  7.x-dev   does not require symfony/filesystem (but v6.4.13 is installed)

As mentioned before, klapaudius/oauth-server-bundle must be updated with Symfony as it doesn't have a version that supports both Symfony 6 and 7.

The bigger issue is the noxlogic/ratelimit-bundle library that doesn't support Symfony 7 at all and there is no sign that it will. I started a Slack thread to quickly decide what to do with it.

The changes in this PR were generated by this command:

composer update knplabs/knp-menu-bundle liip/functional-test-bundle

It updates just minor versions that support Symfony 7. So there should be no BC breaks this time.

This is what the command generates:

Lock file operations: 0 installs, 2 updates, 0 removals
  - Upgrading knplabs/knp-menu-bundle (v3.2.0 => v3.4.2)
  - Upgrading liip/functional-test-bundle (4.9.0 => 4.13.0)

So this is the last step towards the Symfony 7 upgrade until we get over that blocker.

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. knplabs/knp-menu-bundle is used to generate the left and right menu. So you can click through the menu items if you see anything unusual.
  3. liip/functional-test-bundle is a dev dependency and is used in a couple of tests. So if the CI is green we are good.

@escopecz escopecz added ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging dependencies Pull requests that update a dependency file composer Any bugs or PRs relating to composer labels Apr 4, 2025
@escopecz escopecz added this to the 7.0.0-alpha milestone Apr 4, 2025
matbcvo
matbcvo approved these changes Apr 4, 2025
View reviewed changes
Copy link
Contributor

@matbcvo matbcvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me. I tested the PR and found no issues.

@matbcvo matbcvo added code-review-passed PRs which have passed code review pending-test-confirmation PR's that require one test before they can be merged and removed code-review-needed PR's that require a code review before merging ready-to-test PR's that are ready to test labels Apr 4, 2025
@escopecz escopecz merged commit df6c49a into mautic:7.x Apr 5, 2025
15 checks passed
@escopecz escopecz added the enhancement Any improvement to an existing feature or functionality label Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matbcvo matbcvo matbcvo approved these changes

Assignees
No one assigned
Labels
code-review-passed PRs which have passed code review composer Any bugs or PRs relating to composer dependencies Pull requests that update a dependency file enhancement Any improvement to an existing feature or functionality pending-test-confirmation PR's that require one test before they can be merged
Projects
Open Source Fridays
Status: 🥳 Done
Milestone
7.0.0-alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@escopecz @matbcvo