Skip to content

Conversation

JonasLudwig1998
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) ✔️
New feature/enhancement? (use the a.x branch) ✔️❌
Deprecations? ✔️❌
BC breaks? (use the c.x branch) ✔️❌
Automated tests included? ✔️❌
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

When the site url in Mautic is changed in system settings, then the new site url is also used for company details view and company pagination.

Steps to reproduce the error:

  1. Change the site url a new url (in this case: https://newsite.ddev.site)
    image
  2. Now lets verify the wrong behavior. If you now open the 'Companies' tab and hover over a company in your list you should see that the link displayed will use the new site url and not the Mautic url
image

The same happens when you try to switch to page two in your company list
image

This results in you not being able to open neither the company details nor a new page in your company views


📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Change the site url a new url (in this case: https://newsite.ddev.site)
    image
  3. Try to open a company and another page in your company list, both should work

Copy link
Contributor

@oltmanns-leuchtfeuer oltmanns-leuchtfeuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully. Nice Fix! LGMT.

@oltmanns-leuchtfeuer oltmanns-leuchtfeuer added code-review-needed PR's that require a code review before merging pending-test-confirmation PR's that require one test before they can be merged labels Mar 25, 2025
@matbcvo matbcvo added this to the 5.2.5 milestone Mar 27, 2025
Copy link
Contributor

@PatrickJenkner PatrickJenkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as described when tested 👍

@PatrickJenkner PatrickJenkner added user-testing-passed PRs which have been successfully tested by the required number of people. and removed pending-test-confirmation PR's that require one test before they can be merged labels Mar 27, 2025
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issue with this change 👍

@escopecz escopecz added bug Issues or PR's relating to bugs companies Anything related to companies code-review-passed PRs which have passed code review and removed code-review-needed PR's that require a code review before merging labels Mar 27, 2025
@escopecz escopecz merged commit efb4bc6 into mautic:5.2 Mar 27, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs code-review-passed PRs which have passed code review companies Anything related to companies user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants