Fix #14379: Provided options in multiselect fields consolidate users, segments, etc. with same name #14794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Appends the object ID in brackets after the name to ensure clarity. Applied changes across multiple areas: Segments, Campaigns and others. Add new acceptance Test for Multiselect Field Fix.
Closed
1 task
escopecz
approved these changes
Mar 25, 2025
shinde-rahul
approved these changes
Mar 25, 2025
|
@all-contributors please add @1792826181 for code |
|
I've put up a pull request to add @1792826181! 🎉 |
|
Just had a confusion on this when testing where someone thought the number was the number of contacts in a segment (we have fairly large ID in the hundreds). I’ll see if any other reports but wanted to note as it could be worth having it say (ID: x) instead? |
|
@driskell I like that! Just a number without any unit is confusing. But it's already in other places so we should change it at all places. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When multiple objects share the same name in the multiselect fields only one of them would be displayed, making it difficult to select the correct object. This issue affected segments, campaigns, categories, and other entities, leading to user confusion and selection errors.
The problem was caused by the way object lists were indexed using names as keys, which led to duplicate entries being overwritten. To fix this, the logic was updated to append each object's unique ID in parentheses, ensuring clear differentiation. The changes were applied consistently across all affected areas and tests were created to verify that the objects are now properly distinguishable.
📋 Steps to test this PR: