Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.72%. Comparing base (82e71b6) to head (3daba7b).
Report is 31 commits behind head on 5.2.

@@             Coverage Diff              @@
##                5.2   #14780      +/-   ##
============================================
+ Coverage     63.70%   63.72%   +0.01%     
- Complexity    34683    34684       +1     
============================================
  Files          2274     2274              
  Lines        103768   103771       +3     
============================================
+ Hits          66106    66126      +20     
+ Misses        37662    37645      -17     

Cloning doesn't work as expected. I would expect the custom field to be cloned after clicking the Save button once. I currently need to click the Save button three times before the clone is actually created.

Aslo the max character limit field does not inherit the value from the original item - it should be copied automatically during the cloning.

An error also appears after the first attempt to save.

Cloning doesn't work as expected. I would expect the custom field to be cloned after clicking the Save button once. I currently need to click the Save button three times before the clone is actually created.

Aslo the max character limit field does not inherit the value from the original item - it should be copied automatically during the cloning.

An error also appears after the first attempt to save.

Screen.Recording.2025-03-21.140108.mp4

Fixed !
If we tried to clone a fixed field, it remained 'unwritable,' and some properties were not persisted in the clone. Now, it should work like a normal field clone.

I actually like how it is done in segments. If you clone a segment with ID 9 then it will go to route /s/segments/clone/9. It's not edit nor new. Its very clear what's happening and you don't have to somehow store the ID of the original segment in a HTML hidden input or session. That's how it should have been done for all entities. When we are fixing it here, can it be done this way too?

I actually like how it is done in segments. If you clone a segment with ID 9 then it will go to route /s/segments/clone/9. It's not edit nor new. Its very clear what's happening and you don't have to somehow store the ID of the original segment in a HTML hidden input or session. That's how it should have been done for all entities. When we are fixing it here, can it be done this way too?

Now it's using the same logic as segment cloning:

Redirects to:

I'll take a look at the tests later :)

Hey @Hugo-Prossaird, just a heads up, the 5.2.5 release is happening on April 28th. It’d be great if you could resolve those failing tests so we can get it merged in time.

@escopecz one last checkout following your review and related changes and then we can merge ! Thanks :)