Skip to content

Fix #14734: Remove obsolete classes for focus details view #14773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

Fix #14734: Remove obsolete classes for focus details view #14773

merged 1 commit into from
Mar 20, 2025

Conversation

PatrickJenkner
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) ✔️
New feature/enhancement? (use the a.x branch) ❌
Deprecations? ❌
BC breaks? (use the c.x branch) ❌
Automated tests included? ❌
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #14734

Description

Previously, there was a visual bug when displaying focus item details in dark mode where part of the page did not have the correct background color. This PR fixes that.

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Change to dark mode under Account -> Appearance
  3. Create any focus item
  4. Verify that the background color is correct in the details view of the focus item.
  5. Change to another color theme and verify that the background color is still correct.

@PatrickJenkner PatrickJenkner mentioned this pull request Mar 20, 2025
Closed
1 task
@PatrickJenkner PatrickJenkner added bug Issues or PR's relating to bugs user-interface Anything related to appearance, layout, and interactivity ready-to-test PR's that are ready to test mautic-6 labels Mar 20, 2025
@escopecz escopecz self-requested a review March 20, 2025 12:55
escopecz
escopecz approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how it looked before this change:
Screenshot 2025-03-20 at 13 56 20
With this change the background is fixed for the dark theme:
Screenshot 2025-03-20 at 13 57 01
And I see no issue with the light theme either:
Screenshot 2025-03-20 at 13 57 26

Thank you! 👍

@escopecz escopecz added this to the 6.0.0 milestone Mar 20, 2025
@escopecz escopecz added code-review-passed PRs which have passed code review user-testing-passed PRs which have been successfully tested by the required number of people. and removed ready-to-test PR's that are ready to test labels Mar 20, 2025
@escopecz escopecz merged commit b8c71c5 into mautic:6.x Mar 20, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs code-review-passed PRs which have passed code review mautic-6 user-interface Anything related to appearance, layout, and interactivity user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
Open Source Fridays
Status: 🥳 Done
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

Focus items detail not optimal UI in dark mode
2 participants
@PatrickJenkner @escopecz