Codecov Report

Attention: Patch coverage is 93.05556% with 5 lines in your changes missing coverage. Please review.

Project coverage is 64.94%. Comparing base (bad47fb) to head (c116e44).
Report is 267 commits behind head on 7.x.

@@             Coverage Diff              @@
##                7.x   #14759      +/-   ##
============================================
+ Coverage     64.77%   64.94%   +0.16%     
- Complexity    34831    34847      +16     
============================================
  Files          2289     2293       +4     
  Lines        103954   103932      -22     
============================================
+ Hits          67340    67497     +157     
+ Misses        36614    36435     -179     

Tested , working fine.
New field type is available and working fine on add/update Dynamic web content.

I found some potential issues with this implementation:

1. When you first create a DC using type HTML, if you edit it to change to Text, it won't allow you (why?)
2. When you pick Text type, all options for inserting into website keeps visible on details view (is this supposed to be this way? will it work?)
3. There's no documentation explaining how these types work, I'd appreciate information to help me start improving UX

@escopecz @nileshlohar @dadarya0 @fedys Could you clarify how the feature works?

Hi @andersonjeccel,

1. When you first create a DC using type HTML, if you edit it to change to Text, it won't allow you (why?)

This issue was fixed in - #14901

2. When you pick Text type, all options for inserting into website keeps visible on details view (is this supposed to be this way? will it work?)

Which options you mean? Can you share more info or perhaps a screenshot ?

3. There's no documentation explaining how these types work, I'd appreciate information to help me start improving UX

The Type field was introduced to differentiate Text Only DC, which can be used particularly in cases where it is embedded—for example, in an email subject.

@nileshlohar Re. 1, got it

Re. 2:
When you create a Dynamic Content non-campaign-based currently, a slot generator appears when viewing its details for copy-pasting in your website (as the feature was previously about Web only)
This generator was introduced some months ago, before your PR

Questions that come in my mind:

• Can text type be used on a website too, or only in emails?
• Can the HTML type be used in emails, or should this be restricted for web use only?

Depending on the answers, we might need to update display conditions to avoid showing the generator for something users cannot use on the website (or maybe offer an additional option, the token, so they can insert in emails etc)

I'm just trying to understand how these types work and differ before making any UX changes

@andersonjeccel We have more PRs implementing DWC into emails that will be pushed soon if not already. There will be special token to add to emails. We should expand this UI with that new token in the PR that is adding it.

Both the text and HTML type can be used in both emails and pages. The text type is there for special cases like email subject that should not have any HTML markup as Nilesh pointed out.

Hi @nileshlohar I am not seeing any documentation here for end-users or developers. We'll need to have the relevant changes made please. End user would be highest priority, we haven't ported over the dev docs quite yet (cc @mautic/education-team-leaders FYI).

Here's the end-user repo: https://github.com/mautic/user-documentation (I think this page is the most appropriate: https://docs.mautic.org/en/7.0/components/dynamic_web_content.html perhaps?)

Here's the developer docs repo: https://github.com/mautic/developer-documentation-new - I think we haven't brought over the DWC content yet, looks like this is the old docs: https://developer.mautic.org/#dynamic-content.