Skip to content

[UXUI-131] Labels on form details #14757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 23, 2025
Merged

[UXUI-131] Labels on form details #14757

merged 4 commits into from
Mar 23, 2025

Conversation

andersonjeccel
Copy link
Contributor

@andersonjeccel andersonjeccel commented Mar 18, 2025 •
edited
Loading

Q A
Bug fix? (use the a.b branch) ❌
New feature/enhancement? (use the a.x branch) ✔️
Deprecations? ❌
BC breaks? (use the c.x branch) ❌
Automated tests included? ✔️
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

Summary

The issue is about displaying labels for forms when users view their details.

Context

Currently, there are no labels shown for forms during user detail views. This enhancement aims to improve user experience by providing clear labels.

Acceptance criteria

  • Show label when “Disable search indexing“ is enabled (color: blue | icon-only).
  • Show label when “Kiosk mode” is enabled (color: blue | icon-only).
  • Show label for “Language” (color: warm-gray | include tooltip).

Other information

N/A

image

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Open Forms > New > Fill required fields
  3. Also fill Language, set Kiosk mode to On, and Disable search indexing to On
  4. Save & Close then see the form details to check those tags
  5. Edit the form again and disable those functionalities to see tags disappear

@andersonjeccel andersonjeccel self-assigned this Mar 18, 2025
@andersonjeccel andersonjeccel added T1 Low difficulty to fix (issue) or test (PR) code-review-needed PR's that require a code review before merging pending-test-confirmation PR's that require one test before they can be merged user-experience Anything related to related to workflows, feedback, and navigation enhancement Any improvement to an existing feature or functionality forms Anything related to forms labels Mar 18, 2025
@andersonjeccel andersonjeccel moved this to 🦸🏻 Needs 2 tests in Open Source Fridays Mar 18, 2025
@andersonjeccel andersonjeccel moved this to In Progress in UX/UI Tiger Team Mar 18, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.78%. Comparing base (bad47fb) to head (1a6cb14).
Report is 122 commits behind head on 7.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                7.x   #14757   +/-   ##
=========================================
  Coverage     64.77%   64.78%           
- Complexity    34831    34840    +9     
=========================================
  Files          2289     2290    +1     
  Lines        103954   103968   +14     
=========================================
+ Hits          67340    67354   +14     
  Misses        36614    36614
Files with missing lines Coverage Δ
...es/CoreBundle/Twig/Extension/LanguageExtension.php 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kuzmany
kuzmany approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@kuzmany kuzmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.
Did basic tests and works.
Code looks good.

@andersonjeccel andersonjeccel added code-review-passed PRs which have passed code review user-testing-passed PRs which have been successfully tested by the required number of people. and removed code-review-needed PR's that require a code review before merging pending-test-confirmation PR's that require one test before they can be merged labels Mar 19, 2025
@andersonjeccel andersonjeccel moved this from 🦸🏻 Needs 2 tests to 🎉 Ready to commit in Open Source Fridays Mar 19, 2025
@escopecz escopecz added this to the 7.0.0-alpha milestone Mar 23, 2025
@escopecz escopecz merged commit 6cac681 into mautic:7.x Mar 23, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in UX/UI Tiger Team Mar 23, 2025
@github-project-automation github-project-automation bot moved this from 🎉 Ready to commit to 🥳 Done in Open Source Fridays Mar 23, 2025
@andersonjeccel andersonjeccel deleted the UXUI-131-show-labels-when-viewing-forms branch March 23, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuzmany kuzmany kuzmany approved these changes

Assignees

@andersonjeccel andersonjeccel

Labels
code-review-passed PRs which have passed code review enhancement Any improvement to an existing feature or functionality forms Anything related to forms T1 Low difficulty to fix (issue) or test (PR) user-experience Anything related to related to workflows, feedback, and navigation user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
Open Source Fridays
Status: 🥳 Done
UX/UI Tiger Team
Status: Done
Milestone
7.0.0-alpha
Development

Successfully merging this pull request may close these issues.
3 participants
@andersonjeccel @kuzmany @escopecz