Skip to content

[UXUI-88] Select several rows using Shift and clicking with the mouse #14753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 24, 2025
Merged

[UXUI-88] Select several rows using Shift and clicking with the mouse #14753

merged 5 commits into from
Mar 24, 2025
+35 −2

Conversation

andersonjeccel
Copy link
Contributor

@andersonjeccel andersonjeccel commented Mar 18, 2025 •
edited
Loading

Q A
Bug fix? (use the a.b branch) ❌
New feature/enhancement? (use the a.x branch) ✔️
Deprecations? ❌
BC breaks? (use the c.x branch) ❌
Automated tests included? ❌
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

Summary

Enhancement to allow users to select multiple rows in a table by using the Shift key and mouse clicks. This will automatically check all checkboxes within the selected range.

Screencast.From.2025-03-18.09-07-57.mp4

Context

Currently, users can only select rows individually. This enhancement aims to improve user experience by enabling a more efficient selection method.

Acceptance criteria

  • Users can hold the Shift key and click on table rows.
  • All checkboxes in the selected range should be automatically checked.

Other information

N/A

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Go to where rows can be selected (e.g., table from Contacts page).
  3. Click the checkbox of the first row to select.
  4. Press and hold the Shift key.
  5. While holding Shift, click other row to select all rows in between.
  6. Ensure all intended rows are highlighted.
  7. Repeat with different rows for consistent functionality.
  8. After testing, release Shift and check selection remains.

@andersonjeccel andersonjeccel self-assigned this Mar 18, 2025
@andersonjeccel andersonjeccel added T1 Low difficulty to fix (issue) or test (PR) ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging user-experience Anything related to related to workflows, feedback, and navigation enhancement Any improvement to an existing feature or functionality javascript Pull requests that update Javascript code labels Mar 18, 2025
@andersonjeccel andersonjeccel moved this to 🦸🏻 Needs 2 tests in Open Source Fridays Mar 18, 2025
@andersonjeccel andersonjeccel moved this to In Progress in UX/UI Tiger Team Mar 18, 2025
kingsedem
kingsedem approved these changes Mar 23, 2025
View reviewed changes
Copy link

@kingsedem kingsedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Works as expected. Holding Shift, selects all rows in between.
https://screenrec.com/share/byfi4J6nL8

@kingsedem kingsedem added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels Mar 23, 2025
@escopecz escopecz self-requested a review March 24, 2025 12:24
escopecz
escopecz reviewed Mar 24, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Mar 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.92%. Comparing base (bad47fb) to head (368d362).
Report is 128 commits behind head on 7.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                7.x   #14753      +/-   ##
============================================
+ Coverage     64.77%   64.92%   +0.14%     
- Complexity    34831    34834       +3     
============================================
  Files          2289     2290       +1     
  Lines        103954   103876      -78     
============================================
+ Hits          67340    67445     +105     
+ Misses        36614    36431     -183

see 49 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

escopecz
escopecz approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this more. The multiselection with holding command works well 👍

@escopecz escopecz added code-review-passed PRs which have passed code review user-testing-passed PRs which have been successfully tested by the required number of people. and removed code-review-needed PR's that require a code review before merging pending-test-confirmation PR's that require one test before they can be merged labels Mar 24, 2025
@escopecz escopecz added this to the 7.0.0-alpha milestone Mar 24, 2025
@escopecz escopecz merged commit c3a487b into mautic:7.x Mar 24, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in UX/UI Tiger Team Mar 24, 2025
@github-project-automation github-project-automation bot moved this from 🦸🏻 Needs 2 tests to 🥳 Done in Open Source Fridays Mar 24, 2025
@andersonjeccel andersonjeccel deleted the UXUI-88-select-several-rows-using-shift-and-clicking-with-the-mouse branch March 25, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

+1 more reviewer

@kingsedem kingsedem kingsedem approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@andersonjeccel andersonjeccel

Labels
code-review-passed PRs which have passed code review enhancement Any improvement to an existing feature or functionality javascript Pull requests that update Javascript code T1 Low difficulty to fix (issue) or test (PR) user-experience Anything related to related to workflows, feedback, and navigation user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
Open Source Fridays
Status: 🥳 Done
UX/UI Tiger Team
Status: Done
Milestone
7.0.0-alpha
Development

Successfully merging this pull request may close these issues.
3 participants
@andersonjeccel @escopecz @kingsedem