-
-
Notifications
You must be signed in to change notification settings - Fork 3k
[UI] Aligning design decisions #14668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Aligning design decisions #14668
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 7.x #14668 +/- ##
============================================
+ Coverage 64.75% 64.76% +0.01%
- Complexity 34826 34827 +1
============================================
Files 2288 2288
Lines 103943 103951 +8
============================================
+ Hits 67304 67324 +20
+ Misses 36639 36627 -12
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
* Merge pull request mautic#1322 from acquia/MAUT-5432-companies-not-updated-by-form Maut 5432 companies not updated by form * CS, STAN fixes * Fixing "There is no active transaction" in tests --------- Co-authored-by: lukassykora <lukas.sykora@acquia.com> Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
* Merge pull request mautic#1322 from acquia/MAUT-5432-companies-not-updated-by-form Maut 5432 companies not updated by form * CS, STAN fixes * Fixing "There is no active transaction" in tests --------- Co-authored-by: lukassykora <lukas.sykora@acquia.com> Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
…sonjeccel/mautic into reverting-design-decisions
Code review passed and second user testing done in #14741 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
This PR reverts the rounded corners introduced temporarily before the latest releases.
At first, it was important to make people feel that there was a connection between something they already knew previously and the styles of the design system being implemented in the platform about a year ago.
This move was like a bridge to move people from point A to point B. Now that this is done, I'm mainly restoring the original proposal to ensure we can keep improving Mautic.
Why?:
These changes also have impact on accessibility; along the way, I've been implementing several enhancements that rely on how elements behave in this design system (giving fields enough contrast by adding a border at the bottom, for example), they're restored in this PR.
Before:

After:

Before:

After:

Before:

After:

📋 Steps to test this PR: