Skip to content

Conversation

andersonjeccel
Copy link
Contributor

@andersonjeccel andersonjeccel commented Mar 3, 2025

Q A
Bug fix? (use the a.b branch)
New feature/enhancement? (use the a.x branch) ✔️
Deprecations?
BC breaks? (use the c.x branch)
Automated tests included?
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

This PR reverts the rounded corners introduced temporarily before the latest releases.

At first, it was important to make people feel that there was a connection between something they already knew previously and the styles of the design system being implemented in the platform about a year ago.

This move was like a bridge to move people from point A to point B. Now that this is done, I'm mainly restoring the original proposal to ensure we can keep improving Mautic.

Why?:

  • The redesign can now be moved forward faster;
  • Carbon has playground to interact with elements, documentation, backed by UX research, components we could inspect to retrieve CSS code;
  • It looks professional and serious, visually;
  • We'll work on the textual side to make it playful;
  • The final result will be more reliable, given the resources Carbon provides to replicate components (it's open source)
  • Human resources are limited for planning, wireframing and coding to implement, so following something that already exists allows us to deliver a better result, quicker

These changes also have impact on accessibility; along the way, I've been implementing several enhancements that rely on how elements behave in this design system (giving fields enough contrast by adding a border at the bottom, for example), they're restored in this PR.

Before:
image

After:
image

Before:
image

After:
image

Before:
image

After:
image


📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Open several pages and check the squared look

@andersonjeccel andersonjeccel requested a review from RCheesley March 3, 2025 17:50
@andersonjeccel andersonjeccel self-assigned this Mar 3, 2025
@andersonjeccel andersonjeccel added T1 Low difficulty to fix (issue) or test (PR) user-interface Anything related to appearance, layout, and interactivity code-review-needed PR's that require a code review before merging pending-test-confirmation PR's that require one test before they can be merged ux-review-passed labels Mar 3, 2025
@andersonjeccel andersonjeccel added this to the 6.0.0-RC milestone Mar 3, 2025
@andersonjeccel andersonjeccel moved this to ⏳︎ Needs 1 more test in Open Source Fridays Mar 3, 2025
@andersonjeccel andersonjeccel moved this to In Progress in UX/UI Tiger Team Mar 3, 2025
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

❌ Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 64.76%. Comparing base (e524d07) to head (a230d9e).
⚠️ Report is 2180 commits behind head on 7.x.

Files with missing lines Patch % Lines
app/bundles/FormBundle/Form/Type/FieldType.php 96.15% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                7.x   #14668      +/-   ##
============================================
+ Coverage     64.75%   64.76%   +0.01%     
- Complexity    34826    34827       +1     
============================================
  Files          2288     2288              
  Lines        103943   103951       +8     
============================================
+ Hits          67304    67324      +20     
+ Misses        36639    36627      -12     
Files with missing lines Coverage Δ
.../bundles/CategoryBundle/Form/Type/CategoryType.php 100.00% <100.00%> (ø)
app/bundles/FormBundle/Model/SubmissionModel.php 71.19% <100.00%> (+1.64%) ⬆️
app/bundles/FormBundle/Form/Type/FieldType.php 69.13% <96.15%> (+0.96%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@imaabasiee imaabasiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rounded corners across different modules have been reverted to square as intended. Some sreenshots below
image
image

@escopecz escopecz requested a review from Copilot March 5, 2025 10:38
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

@andersonjeccel andersonjeccel added user-testing-passed PRs which have been successfully tested by the required number of people. and removed pending-test-confirmation PR's that require one test before they can be merged labels Mar 7, 2025
andersonjeccel and others added 5 commits March 7, 2025 16:30
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
* Merge pull request mautic#1322 from acquia/MAUT-5432-companies-not-updated-by-form

Maut 5432 companies not updated by form

* CS, STAN fixes

* Fixing "There is no active transaction" in tests

---------

Co-authored-by: lukassykora <lukas.sykora@acquia.com>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
andersonjeccel and others added 13 commits March 12, 2025 14:25
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
* Merge pull request mautic#1322 from acquia/MAUT-5432-companies-not-updated-by-form

Maut 5432 companies not updated by form

* CS, STAN fixes

* Fixing "There is no active transaction" in tests

---------

Co-authored-by: lukassykora <lukas.sykora@acquia.com>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
@andersonjeccel andersonjeccel removed the pending-feedback PR's and issues that are awaiting feedback from the author label Mar 14, 2025
@andersonjeccel andersonjeccel changed the base branch from 6.x to 7.x March 14, 2025 12:48
@andersonjeccel andersonjeccel added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged code-review-passed PRs which have passed code review and removed code-review-needed PR's that require a code review before merging labels Mar 17, 2025
@andersonjeccel andersonjeccel moved this from ⏳︎ Needs 1 more test to 🎉 Ready to commit in Open Source Fridays Mar 17, 2025
@andersonjeccel
Copy link
Contributor Author

Code review passed and second user testing done in #14741

Copy link

@ujale ujale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes confirmed for;
Dashboard
image

Account
image

Company
image

Segments
image

Components > Forms
image
image

Campaigns
image
image

Channels > Emails
image
image

Reports
image

Tags
image

Categories
image

Themes
image

Configuration
image

API Credentials
image

Marketplace
image

Manage Plugins
image

Webhooks
image

@escopecz escopecz merged commit 186f212 into mautic:7.x Mar 19, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from 🎉 Ready to commit to 🥳 Done in Open Source Fridays Mar 19, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in UX/UI Tiger Team Mar 19, 2025
@andersonjeccel andersonjeccel deleted the reverting-design-decisions branch March 19, 2025 11:47
@escopecz escopecz added the enhancement Any improvement to an existing feature or functionality label Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-review-passed PRs which have passed code review enhancement Any improvement to an existing feature or functionality ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged T1 Low difficulty to fix (issue) or test (PR) user-interface Anything related to appearance, layout, and interactivity user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
Status: 🥳 Done
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants