Skip to content

Drop support for PHP 8.1 #14653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 5, 2025
Merged

Drop support for PHP 8.1 #14653

merged 14 commits into from
Mar 5, 2025

Conversation

matbcvo
Copy link
Contributor

@matbcvo matbcvo commented Feb 26, 2025 •
edited
Loading

Q A
Bug fix? (use the a.b branch) ❌
New feature/enhancement? (use the a.x branch) ✔️❌
Deprecations? ✔️❌
BC breaks? (use the c.x branch) ✔️❌
Automated tests included? ✔️
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

This PR drops support for PHP 8.1 because Mautic will be upgraded to Symfony 7.2, which requires PHP 8.2 or higher.

https://symfony.com/releases/7.2

Requires: PHP 8.2.0 or higher

The 7.x branch does not exist yet. I will rebase to the 7.x branch once it is created.

Updated dependencies for PHP 8.2:

  • friendsofphp/proxy-manager-lts:^1.0.16 to friendsofphp/proxy-manager-lts:^1.0.18
  • laminas/laminas-code:^4.7.1 to laminas/laminas-code:^4.16.0
  • symfony/process:^6.4.15 to symfony/process:^6.4.19

After applying Rector fixes for return type declarations, Codecov started complaining (failing the test), so I had to cover them with tests.

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)

@matbcvo matbcvo changed the title Drop support for PHP 8.2 Drop support for PHP 8.1 Feb 26, 2025
@matbcvo matbcvo force-pushed the drop-support-for-php-8-1 branch 2 times, most recently from acfd4c3 to dc4c118 Compare February 26, 2025 18:11
@private-packagist Private Packagist
Copy link

composer.lock

Package changes

Package Operation From To About
friendsofphp/proxy-manager-lts upgrade v1.0.16 v1.0.18 diff
laminas/laminas-code upgrade 4.7.1 4.16.0 diff
symfony/process upgrade v6.4.15 v6.4.19 diff

Settings · Docs · Powered by Private Packagist

@codecov Codecov
Copy link

codecov bot commented Feb 27, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.60%. Comparing base (fb35227) to head (94ea54e).
⚠️ Report is 2381 commits behind head on 7.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                7.x   #14653      +/-   ##
============================================
- Coverage     64.63%   64.60%   -0.04%     
  Complexity    34650    34650              
============================================
  Files          2272     2272              
  Lines        103502   103490      -12     
============================================
- Hits          66901    66862      -39     
- Misses        36601    36628      +27
Files with missing lines Coverage Δ
...tentBundle/Controller/DynamicContentController.php 52.99% <100.00%> (ø)
...pp/bundles/LeadBundle/Entity/OperatorListTrait.php 91.66% <100.00%> (ø)
...les/LeadBundle/Segment/Decorator/BaseDecorator.php 96.29% <100.00%> (ø)
...Bundle/Segment/Decorator/CustomMappedDecorator.php 84.37% <100.00%> (ø)
...e/Segment/Decorator/Date/Other/DateAnniversary.php 63.63% <100.00%> (+9.09%) ⬆️
...undle/Segment/Decorator/Date/Other/DateDefault.php 65.21% <100.00%> (+8.69%) ⬆️
...ment/Decorator/Date/Other/DateRelativeInterval.php 92.59% <100.00%> (+7.40%) ⬆️
...SocialBundle/Integration/FoursquareIntegration.php 7.79% <100.00%> (+2.59%) ⬆️
...cSocialBundle/Integration/InstagramIntegration.php 10.00% <100.00%> (+3.33%) ⬆️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matbcvo matbcvo marked this pull request as ready for review February 27, 2025 07:57
@matbcvo matbcvo force-pushed the drop-support-for-php-8-1 branch from a3c036c to 61c29a1 Compare February 27, 2025 09:21
@matbcvo matbcvo added this to the 7.0.0-alpha milestone Feb 27, 2025
@matbcvo matbcvo added dependencies Pull requests that update a dependency file php Pull requests that update Php code labels Feb 27, 2025
@matbcvo matbcvo force-pushed the drop-support-for-php-8-1 branch 8 times, most recently from a1b88d0 to 08183f1 Compare February 27, 2025 11:41
@matbcvo matbcvo added the automated-tests Anything related to unit, functional or e2e tests label Feb 27, 2025
@matbcvo matbcvo force-pushed the drop-support-for-php-8-1 branch 4 times, most recently from a6b8e98 to db422da Compare February 27, 2025 12:10
@matbcvo matbcvo force-pushed the drop-support-for-php-8-1 branch from db422da to 94ea54e Compare February 27, 2025 12:10
@matbcvo matbcvo added the code-review-needed PR's that require a code review before merging label Feb 27, 2025
@matbcvo
Copy link
Contributor Author

matbcvo commented Feb 27, 2025

Covering them with tests was probably unnecessary, as I see that the codecov/project test still failed. Not sure why. @escopecz?

escopecz
escopecz reviewed Feb 27, 2025
View reviewed changes
@matbcvo matbcvo moved this to 🧑🏻‍💻 Needs a code review in Open Source Fridays Feb 27, 2025
@matbcvo matbcvo changed the base branch from 6.x to 7.x February 27, 2025 12:56
RCheesley
RCheesley approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spun up locally and all seems to be working as expected! Thanks for the PR @matbcvo - I've started a draft here for the 7.0-alpha release notes/blog post, I've added about the PHP version change as a starting point. 🚀

@RCheesley RCheesley requested a review from lenonleite March 5, 2025 14:57
escopecz
escopecz approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issues 👍

@escopecz escopecz merged commit 22abd52 into mautic:7.x Mar 5, 2025
15 of 16 checks passed
@github-project-automation github-project-automation bot moved this from 🧑🏻‍💻 Needs a code review to 🥳 Done in Open Source Fridays Mar 5, 2025
@escopecz escopecz added the enhancement Any improvement to an existing feature or functionality label Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

@RCheesley RCheesley RCheesley approved these changes

@lenonleite lenonleite Awaiting requested review from lenonleite

Assignees
No one assigned
Labels
automated-tests Anything related to unit, functional or e2e tests code-review-needed PR's that require a code review before merging dependencies Pull requests that update a dependency file enhancement Any improvement to an existing feature or functionality php Pull requests that update Php code
Projects
Open Source Fridays
Status: 🥳 Done
Milestone
7.0.0-alpha
Development

Successfully merging this pull request may close these issues.
3 participants
@matbcvo @escopecz @RCheesley