Skip to content

Conversation

andersonjeccel
Copy link
Contributor

@andersonjeccel andersonjeccel commented Jan 30, 2025

Q A
Bug fix? (use the a.b branch) 🟢
New feature/enhancement? (use the a.x branch) 🟢
Deprecations? 🔴
BC breaks? (use the c.x branch) 🔴
Automated tests included? 🔴
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

This PR adds a really simple theme for landing pages

Features:
✅ Custom open source font (Syne) applied to all text and hosted locally (no external servers for improved privacy)
✅ Fonts can be overwritten by users using GrapesJS available fonts
✅ Bg color can be easily changed
✅ Logo won't get distorted when replaced
✅ Really, really fast

Warning

Git configuration added as required by project lead
This PR depends on a fix released in 5.2 that wasn't merged onto 6.x yet

Desktop

Screenshot_30-1-2025_133316_127 0 0 1

Mobile

127 0 0 1_32787_page_preview_16 (1)


📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Open Landing pages > New
  3. Pick Mono
  4. Open the builder and have fun

@andersonjeccel andersonjeccel requested review from a team, LordRembo and mchojrin January 30, 2025 16:25
@andersonjeccel andersonjeccel self-assigned this Jan 30, 2025
@andersonjeccel andersonjeccel added T1 Low difficulty to fix (issue) or test (PR) ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging enhancement Any improvement to an existing feature or functionality forms Anything related to forms landing-pages Anything related to landing pages themes Anything related to themes builder-grapesjs Anything related to the GrapesJS email or landing page builders labels Jan 30, 2025
@andersonjeccel andersonjeccel added this to the 6.0.0-beta milestone Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.21%. Comparing base (e09b6fe) to head (1133a0e).
Report is 1 commits behind head on 6.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                6.x   #14536   +/-   ##
=========================================
  Coverage     64.21%   64.21%           
  Complexity    34568    34568           
=========================================
  Files          2268     2268           
  Lines        103274   103274           
=========================================
  Hits          66319    66319           
  Misses        36955    36955           

@andersonjeccel andersonjeccel added the user-experience Anything related to related to workflows, feedback, and navigation label Jan 30, 2025
Co-authored-by: Martin Vooremäe <martin.vooremae@gmail.com>
@ricfreire
Copy link

I tested the theme as requested by @RCheesley.

Nothing to add, works as expected.

@andersonjeccel andersonjeccel added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging labels Feb 21, 2025
@andersonjeccel andersonjeccel added code-review-passed PRs which have passed code review user-testing-passed PRs which have been successfully tested by the required number of people. labels Feb 21, 2025
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the version!

@RCheesley RCheesley merged commit b467e30 into mautic:6.x Feb 21, 2025
18 checks passed
@RCheesley
Copy link
Member

https://github.com/mautic/theme-mono now created - just re-running the git-split as I forgot to do it before merging! 😊

@andersonjeccel andersonjeccel deleted the mono-theme branch February 24, 2025 07:26
@RCheesley RCheesley modified the milestones: 6.0.0-beta, 6.0.0-beta2 Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builder-grapesjs Anything related to the GrapesJS email or landing page builders code-review-passed PRs which have passed code review enhancement Any improvement to an existing feature or functionality forms Anything related to forms landing-pages Anything related to landing pages ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged T1 Low difficulty to fix (issue) or test (PR) themes Anything related to themes user-experience Anything related to related to workflows, feedback, and navigation user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
Status: 🥳 Done
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants