Skip to content

DPMMA-3033 Correct focus item script response codes and fix undefined Focus.iframe #14521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2025
Merged

DPMMA-3033 Correct focus item script response codes and fix undefined Focus.iframe #14521

merged 1 commit into from
Mar 24, 2025

Conversation

patrykgruszka
Copy link
Member

@patrykgruszka patrykgruszka commented Jan 28, 2025 •
edited
Loading

Q A
Bug fix? (use the a.b branch) 🟢
New feature/enhancement? (use the a.x branch) 🔴
Deprecations? 🔴
BC breaks? (use the c.x branch) 🔴
Automated tests included? 🟢
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

This PR fixes some JS errors in browser when Focus.iframe is not defined and corrects the response codes when Focus Item doesn't exist.
image

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Check the response code of focus item that doesn't exist, for example: https://mautic.ddev.site/focus/111111.js should have code 404
    image
  3. Add the focus item that will be displayed after scrolling to middle of the page
    Screenshot from 2025-01-28 13-54-27
  4. Add the focus item to landing page scripts
    image
  5. Check if the console log has any errors
    image

@matbcvo matbcvo added bug Issues or PR's relating to bugs focus-items Anything related to focus items labels Jan 28, 2025
@matbcvo matbcvo added this to the 5.2.3 milestone Jan 28, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.49%. Comparing base (2fbc4b8) to head (1355571).
Report is 107 commits behind head on 5.2.

Files with missing lines Patch % Lines
.../MauticFocusBundle/Controller/PublicController.php 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                5.2   #14521   +/-   ##
=========================================
  Coverage     63.48%   63.49%           
  Complexity    34637    34637           
=========================================
  Files          2273     2273           
  Lines        103613   103613           
=========================================
+ Hits          65779    65788    +9     
+ Misses        37834    37825    -9
Files with missing lines Coverage Δ
.../MauticFocusBundle/Controller/PublicController.php 39.13% <50.00%> (+39.13%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matbcvo matbcvo added ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging labels Jan 29, 2025
@nick-vanpraet nick-vanpraet modified the milestones: 5.2.3, 5.2.4 Feb 24, 2025
matbcvo
matbcvo approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@matbcvo matbcvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me. I've tested the PR, and it works as expected. 👍

5.2 branch

image

image

PR

image

image

@matbcvo matbcvo added pending-test-confirmation PR's that require one test before they can be merged code-review-passed PRs which have passed code review and removed ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging labels Mar 11, 2025
@matbcvo matbcvo moved this from 🦸🏻 Needs 2 tests to ⏳︎ Needs 1 more test in Open Source Fridays Mar 11, 2025
@matbcvo matbcvo added the T1 Low difficulty to fix (issue) or test (PR) label Mar 20, 2025
escopecz
escopecz approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issues with the code changes 👍

@escopecz escopecz added user-testing-passed PRs which have been successfully tested by the required number of people. and removed pending-test-confirmation PR's that require one test before they can be merged labels Mar 24, 2025
@escopecz escopecz merged commit 59be2bf into mautic:5.2 Mar 24, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from ⏳︎ Needs 1 more test to 🥳 Done in Open Source Fridays Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matbcvo matbcvo matbcvo approved these changes

@escopecz escopecz escopecz approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs code-review-passed PRs which have passed code review focus-items Anything related to focus items T1 Low difficulty to fix (issue) or test (PR) user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
Open Source Fridays
Status: 🥳 Done
Milestone
5.2.4
Development

Successfully merging this pull request may close these issues.
4 participants
@patrykgruszka @matbcvo @escopecz @nick-vanpraet