Skip to content

Conversation

andersonjeccel
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) 🔴
New feature/enhancement? (use the a.x branch) 🟢
Deprecations? 🔴
BC breaks? (use the c.x branch) 🔴
Automated tests included? 🔴
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

This PR updates Remix icon pack from 4.3.0 to 4.6.0


@andersonjeccel andersonjeccel self-assigned this Jan 28, 2025
@andersonjeccel
Copy link
Contributor Author

@escopecz How to label a PR like this?

@andersonjeccel andersonjeccel added this to the 6.0.0-beta milestone Jan 28, 2025
@matbcvo matbcvo added enhancement Any improvement to an existing feature or functionality dependencies Pull requests that update a dependency file labels Jan 28, 2025
@matbcvo matbcvo added the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Jan 28, 2025
@andersonjeccel
Copy link
Contributor Author

I would really like to make this package more maintainable, but there’s an issue where the original file provided by Remix adds all classes within :global (like :root in CSS) resulting in a generated CSS file that doesn’t work

so every time I need to manually create a new path for font-face as using the original path would lead to errors

any ideas?

@escopecz escopecz merged commit 8005ca1 into mautic:6.x Jan 29, 2025
17 checks passed
@andersonjeccel andersonjeccel deleted the update-remix-icon-pack branch January 29, 2025 09:59
@RCheesley RCheesley modified the milestones: 6.0.0-beta, 6.0.0-beta2 Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement Any improvement to an existing feature or functionality ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants