Skip to content

Conversation

andersonjeccel
Copy link
Contributor

@andersonjeccel andersonjeccel commented Jan 27, 2025

Q A
Bug fix? (use the a.b branch) 🟢
New feature/enhancement? (use the a.x branch) 🟢
Deprecations? 🔴
BC breaks? (use the c.x branch) 🔴
Automated tests included? 🔴
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

This PR makes marketer's life easier by showing which kind of field something is, without having to edit it.

shows info about form fields at a glance when building them, as sometimes having no header for preview can't tell you which kind of field this is, or purpose

UX planning

Colors

Green: For addition or growth actions (e.g., adding points, multiplying values).
Red: For removal, reduction, or division actions (when representing a decrease).
Blue: For filling in, updating data, or neutral/configurable actions.
Neutral (Gray): Represents relationship or when no specific action is being performed.

Other aspects

  • Features use filled icons to express active state, while resources (segments, emails etc) use lined icons
  • The field type label uses a high contrast color to teach how your eyes must navigate through the list, always first to create a location pattern
  • All icon-only icons have tooltips
  • Required is always at the right of the container
  • Labels with border indicate they're operational (links; available only for actions in the next PR from this series)
  • Ensures no weird things keep visible when there are no visible labels
  • Includes fallbacks for icons and custom objects

image

Before:

image

After:

image


📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Open Forms > New
  3. Open Fields tab
  4. Add absolutely all types of fields
  5. Play with their configurable options
  6. Check how they look on the list

@andersonjeccel andersonjeccel added T1 Low difficulty to fix (issue) or test (PR) ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging user-experience Anything related to related to workflows, feedback, and navigation enhancement Any improvement to an existing feature or functionality twig forms Anything related to forms labels Jan 27, 2025
@andersonjeccel andersonjeccel added this to the 6.0.0-beta milestone Jan 27, 2025
@andersonjeccel andersonjeccel requested review from shinde-rahul, kuzmany and escopecz and removed request for mchojrin and laurielim January 29, 2025 14:38
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no problem in this code change. It would be nice to have a custom Twig extension for the typeIcons that would allow plugins to add to the list but I think the fallback is good enough at this point. It can always be added later.

For the testers, please test also the form behaviour also as a contact if all the progressive profiling still works.

@escopecz escopecz added code-review-passed PRs which have passed code review and removed code-review-needed PR's that require a code review before merging labels Feb 5, 2025
Copy link
Contributor

@shinde-rahul shinde-rahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

Thank you, @andersonjeccel!!!

@escopecz escopecz added user-testing-passed PRs which have been successfully tested by the required number of people. and removed ready-to-test PR's that are ready to test labels Feb 6, 2025
@escopecz escopecz merged commit 7f95afd into mautic:6.x Feb 6, 2025
17 checks passed
@andersonjeccel andersonjeccel deleted the better-fields-when-creating-forms branch February 10, 2025 13:52
@RCheesley RCheesley modified the milestones: 6.0.0-beta, 6.0.0-beta2 Mar 5, 2025
@mautibot
Copy link
Contributor

mautibot commented Mar 6, 2025

This pull request has been mentioned on Mautic Forums. There might be relevant details there:

https://forum.mautic.org/t/announcing-mautic-6-beta-now-available-for-testing/35196/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-review-passed PRs which have passed code review enhancement Any improvement to an existing feature or functionality forms Anything related to forms T1 Low difficulty to fix (issue) or test (PR) twig user-experience Anything related to related to workflows, feedback, and navigation user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
Status: 🥳 Done
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants