-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix dynamic content token replacement for external plugins #14599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.2 #14599 +/- ##
============================================
- Coverage 63.70% 63.70% -0.01%
+ Complexity 34684 34682 -2
============================================
Files 2274 2274
Lines 103771 103766 -5
============================================
- Hits 66111 66106 -5
Misses 37660 37660
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested and does exactly what it should. LGTM! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We build fix for this issue #14959
But this works too 👍
Description
This is another approach to the PR #13226
The issue:
Currently custom filters can not be applied to tokens, that are actually strings, like
{dwc=slot-name}
, because the current code does not executeContactFiltersEvaluateEvent
in that case, but replaces tokens with an empty string.📋 Steps to test this PR:
data-slot="dwc"
and "inline text DWC"{dwc=slot-name}
If the PR is not applied the result is following:

Check the contact event log (you should enable anonymous contacts in the list to see new results):

On the screenshot below the first entry (3 rows in the bottom) are log entries when the PR is active, and the rest (last four entries) are when the PR is not active.
You could also create additional slots to check if the previous functionality works as expected.