Skip to content

Pull-request-template #14585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 12, 2025
Merged

Pull-request-template #14585

merged 2 commits into from
Feb 12, 2025

Conversation

Jaishree2310
Copy link
Contributor

@Jaishree2310 Jaishree2310 commented Feb 11, 2025 •
edited by escopecz
Loading

Signed-off-by: Jaishree2310 jaishrees23102001@gmail.com

Q A
Bug fix? (use the a.b branch) 🔴🟢
New feature/enhancement? (use the a.x branch) 🔴🟢
Deprecations? 🔴🟢
BC breaks? (use the c.x branch) 🔴🟢
Automated tests included? 🔴🟢
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #14529

Description

📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)

escopecz
escopecz requested changes Feb 11, 2025
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the files in the .ddev folder form this PR as I assume they were pushed by accident.

@escopecz escopecz added bug Issues or PR's relating to bugs pending-feedback PR's and issues that are awaiting feedback from the author labels Feb 11, 2025
@matbcvo
Copy link
Contributor

matbcvo commented Feb 11, 2025 •
edited
Loading

I'm not sure a thumbs up/down is the best replacement. Wouldn't a checkmark (✔️) and a cross (❌) be more suitable instead?

@Jaishree2310
Copy link
Contributor Author

I'm not sure a thumbs up/down is the best replacement. Wouldn't a checkmark (✔️) and a cross (❌) be more suitable instead?

Yeap I was changing this to checkbox

This was referenced Feb 12, 2025
Closed
Closed
escopecz
escopecz approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good with me. Thank you! 👍

@escopecz escopecz added pending-test-confirmation PR's that require one test before they can be merged and removed pending-feedback PR's and issues that are awaiting feedback from the author labels Feb 12, 2025
@escopecz escopecz linked an issue Feb 12, 2025 that may be closed by this pull request
The PR template is hard to see for people who does not see colors proper. #14529
Closed
1 task
@codecov Codecov
Copy link

codecov bot commented Feb 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.08%. Comparing base (7a4aace) to head (92d697f).
Report is 3 commits behind head on 6.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                6.x   #14585      +/-   ##
============================================
- Coverage     64.08%   64.08%   -0.01%     
  Complexity    34538    34538              
============================================
  Files          2266     2266              
  Lines        103191   103191              
============================================
- Hits          66130    66129       -1     
- Misses        37061    37062       +1

see 1 file with indirect coverage changes

@escopecz escopecz added ready-to-test PR's that are ready to test user-experience Anything related to related to workflows, feedback, and navigation and removed pending-test-confirmation PR's that require one test before they can be merged labels Feb 12, 2025
@escopecz escopecz added this to the 6.0.0-beta milestone Feb 12, 2025
@escopecz escopecz merged commit a567582 into mautic:6.x Feb 12, 2025
17 checks passed
@escopecz
Copy link
Member

@all-contributors please add @Jaishree2310 for doc

@allcontributors allcontributors bot mentioned this pull request Feb 12, 2025
Merged
@allcontributors AllContributors
Copy link
Contributor

@escopecz

I've put up a pull request to add @Jaishree2310! 🎉

@RCheesley RCheesley modified the milestones: 6.0.0-beta, 6.0.0-beta2 Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matbcvo matbcvo matbcvo approved these changes

@escopecz escopecz escopecz approved these changes

@andersonjeccel andersonjeccel Awaiting requested review from andersonjeccel

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test user-experience Anything related to related to workflows, feedback, and navigation
Projects
Open Source Fridays
Status: 🥳 Done
Milestone
6.0.0-beta2
Development

Successfully merging this pull request may close these issues.

The PR template is hard to see for people who does not see colors proper.
4 participants
@Jaishree2310 @matbcvo @escopecz @RCheesley